http: fix missing close event on aborted response #1373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending a response after client aborted the connection in the same tick when the socket is already destroyed but the socket-close event is still not delivered, you did not get either a response-finish or a response-close event. This fix of the race-condition needs an additional flag "_finishOrCloseEmitted" in OutgoingMessage.
|
cc @indutny? |
| var testTickCount = 3; | ||
|
|
||
| var server = http.createServer(function (req, res) { | ||
| console.log('server: request'); |
There was a problem hiding this comment.
usually, passing tests should be silent; could you remove the expected console.logs?
There was a problem hiding this comment.
Of course I could remove them - I kept with the other tests which also contain console.logs (output is hidden anyway in normal test run).
I thought, especially race conditions are much more understandable with some debugging output - also for future refactoring/debugging.
There was a problem hiding this comment.
Please keep them for now :) I've a bit delayed this, but going to review it next week!
indutny
pushed a commit
to indutny/io.js
that referenced
this pull request
Apr 13, 2015
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <[email protected]>
indutny
added a commit
to indutny/io.js
that referenced
this pull request
Apr 13, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
|
@not-implemented PTAL at #1411 . I have integrated your test, but decided to choose a bit different way to fix the issue. |
|
Thank you for discovering this! |
|
Ah very cool ... I didn't have the guts to delay the WHOLE finish-handling - only parts of it ;-) |
|
Thank you! |
indutny
pushed a commit
to indutny/io.js
that referenced
this pull request
Apr 15, 2015
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <[email protected]>
indutny
added a commit
to indutny/io.js
that referenced
this pull request
Apr 15, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
indutny
pushed a commit
to indutny/io.js
that referenced
this pull request
Jun 1, 2015
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <[email protected]>
indutny
added a commit
to indutny/io.js
that referenced
this pull request
Jun 1, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
indutny
added a commit
that referenced
this pull request
Jun 5, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Jun 17, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
pushed a commit
that referenced
this pull request
Jul 4, 2015
See next commit for the actual fix. PR-URL: #1373 Reviewed-By: Fedor Indutny <[email protected]>
indutny
pushed a commit
that referenced
this pull request
Jul 4, 2015
See next commit for the actual fix. PR-URL: #1373 Reviewed-By: Fedor Indutny <[email protected]>
indutny
added a commit
that referenced
this pull request
Jul 22, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Jul 24, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Jul 30, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Aug 1, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Aug 3, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Aug 4, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
indutny
added a commit
that referenced
this pull request
Aug 4, 2015
Do not detach the socket from the response until all data is actually sent to the other side. See: #1373 PR-URL: #1411 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a response after client aborted the connection in the same tick when the socket is already destroyed but the socket-close event is still not delivered, you did not get either a response-finish or a response-close event.
This fix of the race-condition needs an additional flag "_finishOrCloseEmitted" in OutgoingMessage.
I did not find any easier solution - I tried to fix this either with an additional "close" or an additional "finish" with some timing-tricks without an additional flag. I had no chance without breaking anything else.
Not all of the new checks of "_finishOrCloseEmitted" are currently really needed - they are just for completeness.