Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: - line #354 - comment typo. "iff" corrected #13496

Closed
wants to merge 5 commits into from
Closed

events: - line #354 - comment typo. "iff" corrected #13496

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cc31c0
events: - line #354 - comment typo. "iff" corrected
jonsey247 Jun 6, 2017
ca72caf
events: - line #354 - "iff" changed to "if and only if".
jonsey247 Jun 6, 2017
02e4a4b
events: - line #354 - if and only if updated. events: - line #354 -em…
jonsey247 Jun 6, 2017
10631db
events: - line #354 - if and only if updated. events: - line #354 Emi…
jonsey247 Jun 6, 2017
15ec99b
-m'no change'
jonsey247 Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ EventEmitter.prototype.prependOnceListener =
return this;
};

// emits a 'removeListener' event iff the listener was removed
// emits a 'removeListener' event if and only if the listener was removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally optional, but while you're in here, if you want, emits -> Emits and put a . at the end. I'm pretty sure we have Collaborators that strongly prefer that style (especially the capitalization), but I also know we have lots of comments that don't conform to it. So totally OK if you don't do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it would read:
emits -> Emits a 'removeListener' event if and only if the listener was removed.
??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. (And like I said: Totally optional!)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For that matter, it's something that whoever lands the PR can fix up if they want to.)

Copy link
Contributor

@refack refack Jun 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonsey247 I'll land this. Comment if you want me to fix the sentence?

EventEmitter.prototype.removeListener =
function removeListener(type, listener) {
var list, events, position, i, originalListener;
Expand Down