doc: document method for reverting commits #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
May 13, 2017
COLLABORATOR_GUIDE.md
Outdated
| @@ -252,6 +252,10 @@ not can often be based on many complex factors that are not easily codified. It | |||
| is also possible that the breaking commit can be labeled retroactively as a | |||
| semver-major change that will not be backported to Current or LTS branches. | |||
|
|
|||
| Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for | |||
There was a problem hiding this comment.
A subsection header might be appropriate here.
joyeecheung
reviewed
May 14, 2017
lpinca
approved these changes
May 14, 2017
@joyeecheung why not! Done |
benjamingr
approved these changes
May 14, 2017
joyeecheung
approved these changes
May 14, 2017
jasnell
approved these changes
May 15, 2017
PR-URL: nodejs#13015 Fixes: nodejs#12979 Refs: nodejs#4679 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#13015 Fixes: nodejs#12979 Refs: nodejs#4679 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jun 22, 2017
PR-URL: #13015 Fixes: #12979 Refs: #4679 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #13015 Fixes: #12979 Refs: #4679 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12979
Refs: #4679 (comment)
Checklist
Affected core subsystem(s)
doc