Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove eslint comments #12669

Merged
merged 2 commits into from
Apr 28, 2017
Merged

test: remove eslint comments #12669

merged 2 commits into from
Apr 28, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 26, 2017

This PR refactors two tests to remove the need for ESLint comments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 26, 2017
mhdawson
mhdawson approved these changes Apr 27, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/7730/

@cjihrig
test: remove eslint comments
8d1f15b 
This commit refactors test-whatwg-url-tojson.js to remove
ESLint comments.

PR-URL: nodejs#12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@cjihrig
test: remove eslint comments from test-util.js
b2c7a51 
PR-URL: nodejs#12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@cjihrig cjihrig merged commit b2c7a51 into nodejs:master Apr 28, 2017
@cjihrig cjihrig deleted the eslint branch April 28, 2017 17:12
Trott
Trott reviewed Apr 28, 2017
View reviewed changes
test/parallel/test-whatwg-url-tojson.js
assert_equals(JSON.stringify(a), "\"https://example.com/\"")
})
/* eslint-enable */
const a = new URL('https://example.com/');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I don't think we wanted to make this change because now we can't do straight copy/paste from https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html anymore. (Or is that test unlikely to ever change so this is OK? /cc @TimothyGu @joyeecheung)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be reverted..also, the test suites are dual-licensed. I am not sure which license we are using but generally:

performance claims can only be made against unaltered tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to have useful comments in place for these cases then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig Not sure if it's a good idea to put a link to https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#imported-tests ? (the link can change though)

Revert opened in #12743

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real opinion on whether we should link to that or not, but we should definitely say something along the lines of do not modify. Preferably right next to the eslint disable comment.

@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@cjihrig @evanlucas
test: remove eslint comments
5989b41 
This commit refactors test-whatwg-url-tojson.js to remove
ESLint comments.

PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 1, 2017
@cjihrig @evanlucas
test: remove eslint comments from test-util.js
46fda89 
PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gibfahn gibfahn mentioned this pull request May 2, 2017
Closed
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
test: remove eslint comments
98f3c0f 
This commit refactors test-whatwg-url-tojson.js to remove
ESLint comments.

PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
test: remove eslint comments from test-util.js
e2dfd4f 
PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
test: remove eslint comments
dd1dced 
This commit refactors test-whatwg-url-tojson.js to remove
ESLint comments.

PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
test: remove eslint comments from test-util.js
79dff99 
PR-URL: #12669
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented May 15, 2017

Adding dont-land-on label, let me know if it should be landed.

@gibfahn gibfahn mentioned this pull request Jun 18, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@Trott Trott Trott left review comments

@gibfahn gibfahn gibfahn approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aqrln aqrln aqrln approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @mhdawson @gibfahn @refack @jasnell @evanlucas @Trott @joyeecheung @aqrln @nodejs-github-bot