Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-gyp: allow node.exe/iojs.exe to be renamed #1251

Merged
merged 1 commit into from
Mar 25, 2015
Merged

node-gyp: allow node.exe/iojs.exe to be renamed #1251

merged 1 commit into from
Mar 25, 2015

Commits on Mar 25, 2015

  1. win,node-gyp: allow node.exe/iojs.exe to be renamed 

    On Windows, when node or io.js attempts to dynamically load a compiled
addon, the compiled addon tries to load node.exe or iojs.exe again -
depending on which import library the module used when it was linked.
This makes it impossible to rename node.exe or iojs.exe, because when
that happens the module can't find its dependencies.

With this patch, a delay-load hook is added to all modules that are
compiled with node-gyp. The delay-load hook ensures that whenever a
module tries to load imports from node.exe/iojs.exe, it'll just refer
back to the process image, thus making it possible to rename the
iojs/node binary.

Bug: nodejs#751
Bug: nodejs#965
Upstream PR: nodejs/node-gyp#599

PR-URL: nodejs#1251
Reviewed-By: Rod Vagg <[email protected]>
    @piscisaureus
    piscisaureus committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    3d46fef View commit details
    Browse the repository at this point in the history