Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: ensure that streams2 won't .end() stdin #1233

Closed
wants to merge 2 commits into from
Closed

node: ensure that streams2 won't .end() stdin #1233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94975ad
node: ensure that streams2 won't `.end()` stdin
indutny Mar 21, 2015
a365fc4
...
indutny Mar 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,8 @@
writable: false
});
}
// Ensure that Streams2 won't try to `.end()` the stream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might rephrase this comment to make sure that stdin can't be .end()-ed, since we're on streams3 now.

stdin._writableState.ended = true;
break;

default:
Expand Down