Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test clusters --inspect-brk and --debug-brk #11471

Closed
wants to merge 8 commits into from
Closed

test: test clusters --inspect-brk and --debug-brk #11471

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63e78ed
test: test clusters --inspect-brk and --debug-brk
Feb 21, 2017
e2c86af
test: test clusters --inspect-brk and --debug-brk
Feb 21, 2017
c6c73d2
remove unwanted comments
Feb 21, 2017
e7b1975
fix review comments:
Feb 27, 2017
ab85649
fix based on review comments
Feb 28, 2017
e1ccdcb
fix linting error
Mar 2, 2017
c39b078
fix linting error
Mar 3, 2017
9f9a725
fix test failure on CI machines
Mar 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions test/parallel/test-cluster-inspector-debug-brk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict';
// This test ensures that flag --inspect-brk and --debug-brk works properly

const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');

const script = common.fixturesDir + '/empty.js';

function fail() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, please use common.fail() or common.mustNotCall(), which are designed to do essentially this same thing without cluttering up the tests.

assert(0); // `node --debug-brk script.js` should not quit
}

if (cluster.isMaster) {

function fork(execArgv) {
cluster.setupMaster({execArgv});
let worker = cluster.fork();

worker.on('exit', fail);

// give node time to start up the debugger
setTimeout(() => {
worker.removeListener('exit', fail);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having this fail() function and the process.on('exit', ...) block, it might be better to use the cluster worker exit event and check the exit code and signal to make sure it was killed by signal (there is an example in the docs).

worker.kill();
}, 2000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a recipe for a flaky test, I'd suggest waiting until the debug/inspect TCP port is open/can be connected to


return worker;
}

let workers = [
fork([script, '--inspect-brk']),
fork([script, `--inspect-brk=5959`]),
fork([script, '--debug-brk']),
fork([script, `--debug-brk=9230`])
];

process.on('exit', function() {
workers.map((wk) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want forEach(), not map().

assert.equal(wk.process.killed, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use assert.strictEqual().

});
});
}