test: skip IPv6 test on non-IPv6 systems #11432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until recently, test-dgram-address would fail on IPv6 but still exit with a successful return code. (It would console.log() the error but not actually fail.) Now that the test has been updated such that it will fail the IPv6 part of the test if there is an error event emitted by the socket, skip the test on systems not equipped with IPv6.
Trott
added
dgram
|
This fixes an issue that is currently causing CI to fail every time for two of the three Raspberry Pi setups we have in CI. I propose not waiting the 48 hours on this one and landing much sooner. /cc @nodejs/testing @cjihrig |
jasnell
approved these changes
Feb 16, 2017
cjihrig
approved these changes
Feb 16, 2017
evanlucas
approved these changes
Feb 16, 2017
|
CI again (build failure on one host): https://ci.nodejs.org/job/node-test-pull-request/6456/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 17, 2017
Until recently, test-dgram-address would fail on machines without IPv6 but still exit with a successful return code. (It would console.log() the error but not actually fail.) Now that the test has been updated such that it will fail the IPv6 part of the test if there is an error event emitted by the socket, skip the test on systems not equipped with IPv6. PR-URL: nodejs#11432 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
Landed in d9a14b7 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Until recently, test-dgram-address would fail on machines without IPv6 but still exit with a successful return code. (It would console.log() the error but not actually fail.) Now that the test has been updated such that it will fail the IPv6 part of the test if there is an error event emitted by the socket, skip the test on systems not equipped with IPv6. PR-URL: nodejs#11432 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Feb 21, 2017
Until recently, test-dgram-address would fail on machines without IPv6 but still exit with a successful return code. (It would console.log() the error but not actually fail.) Now that the test has been updated such that it will fail the IPv6 part of the test if there is an error event emitted by the socket, skip the test on systems not equipped with IPv6. PR-URL: #11432 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
needs backport PRs in order to land on v6 or v4 |
This was referenced Nov 29, 2023
This was referenced Dec 10, 2023
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until recently, test-dgram-address would fail on machines without IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)
Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram