Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix incorrect indentation #11219

Closed
wants to merge 1 commit into from
Closed

test: fix incorrect indentation #11219

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 7, 2017

Indentaiton is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig
test: fix incorrect indentation
61e5e17 
Indentaiton is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2017
bnoordhuis
bnoordhuis approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although if the linter isn't complaining...

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 7, 2017

I'm more curious as to why the linter isn't complaining. I experimented with the file a little bit, and it wasn't complaining at other incorrect indentation levels. cc: @not-an-aardvark

@not-an-aardvark
Copy link
Contributor

It's happening because we have the ObjectExpression: first option configured, which verifies that all properties must be aligned with the first property, but is designed to not validate the indentation of the first property. In the next major release, it's likely that the linter will validate that the first property has the normal level of indentation.

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Feb 7, 2017
@mscdex
Copy link
Contributor

mscdex commented Feb 7, 2017

Minor nit: there's a typo in the commit message.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6301/

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

Landed in c239581. Thanks.

@cjihrig cjihrig closed this Feb 9, 2017
@cjihrig cjihrig deleted the indentation branch February 9, 2017 17:13
cjihrig added a commit that referenced this pull request Feb 9, 2017
@cjihrig
test: fix incorrect indentation
c239581 
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: #11219
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@cjihrig @italoacasas
test: fix incorrect indentation
7e8386c 
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: #11219
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: fix incorrect indentation
540dca1 
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: nodejs#11219
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@cjihrig @krydos
test: fix incorrect indentation
7523066 
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: nodejs#11219
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @not-an-aardvark @mscdex @bnoordhuis @jasnell @joyeecheung @MylesBorins @nodejs-github-bot