doc: add common.WPT to test README #11127
Conversation
Trott
added
doc
|
(This documentation is a stub.) |
test/README.md
Outdated
| ### WPT | ||
|
|
||
| An implementation of parts of the W3C Web Platform Test harness. It is used in | ||
| to test WHATWG URL conformance. |
There was a problem hiding this comment.
A link would be helpful (Web Platform Tests and/or testharness.js). Also the second sentence seems to have an extra "in".
|
I personally don't really think it's necessary to extend this documentation stub, when |
|
@TimothyGu Thanks. I incorporated both links and got a little more specific with the text. PTAL. |
test/README.md
Outdated
|
|
||
| ### WPT | ||
|
|
||
| An implementation of parts of |
There was a problem hiding this comment.
I would say it's more like a "mock" or "port"? But this description LGTM too.
There was a problem hiding this comment.
"port" works for me. I'll change it.
Trott
force-pushed
the
wpt
branch
2 times, most recently
from
d28ea8c
to
c284e24
Compare
| @@ -379,3 +379,12 @@ The realpath of the 'tmp' directory. | |||
| * return [<String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type) | |||
|
|
|||
| Name of the temp directory used by tests. | |||
|
|
|||
| ### WPT | |||
There was a problem hiding this comment.
Maybe ### WPT (Web Platform Tests) for people who don't know what it is and don't see the link two lines down?
There was a problem hiding this comment.
Parentheses are used to show arguments in the other entries so I probably wouldn't do it exactly that way. But if there's a way to clarify it in the text below, I'm happy to.
There was a problem hiding this comment.
Maybe just start the next line with it, something like:
Web Platform Tests - A port of parts of
test/README.md
Outdated
| A port of parts of | ||
| [W3C testharness.js](https://github.com/w3c/testharness.js) for testing the | ||
| Node.js | ||
| [WHATWG URL API](https://github.com/nodejs/node/blob/master/doc/api/url.md#the-whatwg-url-api) |
There was a problem hiding this comment.
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 3fffebb |
PR-URL: #11127 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
Affected core subsystem(s)
doc test