test: update V8 flag in test #10917
Closed
test: update V8 flag in test #10917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists.
nodejs-github-bot
added
test
targos
approved these changes
Jan 20, 2017
mscdex
added
process
targos
pushed a commit
to targos/node
that referenced
this pull request
Jan 22, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: nodejs#10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 4f8582e |
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: #10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: nodejs#10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: nodejs#10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
This will need a backport PR if it needs to land in v4. Landing in v6. |
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: #10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag that still exists. PR-URL: #10917 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--expose-debug-asis going away in V8 5.8. Switchtest-preload.jsto a flagthat still exists.
R=@nodejs/v8
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test