Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 4.1.1 #10781

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 4.1.1 #10781

wants to merge 1 commit into from

Conversation

iarna
Copy link
Member

@iarna iarna commented Jan 13, 2017

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change
  • Adds opt-in anonymous success/fail metrics reporting.
  • Adds the new npm doctor command.
  • Bug fix to a major source of shasum-mismatch errors.
  • Fix file URL handling with Node.js 7+
Changelogs

r: @Fishrock123
r: @addaleax
r: @jasnell

@iarna iarna added dont-land-on-v4.x npm Issues and PRs related to the npm client dependency or the npm registry. labels Jan 13, 2017
@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jan 13, 2017
@jasnell
Copy link
Member

jasnell commented Jan 13, 2017

Will be able to give this a more thorough review later on but just quickly on the file URL bit... once the new WHATWG URL stuff moves out of experimental, it's handling of file:// URL parsing would be considered canonical. (I am currently considering a proposal to backport the new parser to v6 and v4)

Fishrock123
Fishrock123 approved these changes Jan 13, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm tests pass

@zkat zkat mentioned this pull request Jan 26, 2017
Closed
4 tasks
@Fishrock123
Copy link
Contributor

Oops, forgot to merge this. D:

Doing it now!

@Fishrock123
Copy link
Contributor

Thanks, landed in f73bc91

Fishrock123 pushed a commit that referenced this pull request Jan 26, 2017
@iarna @Fishrock123
deps: upgrade npm to 4.1.1
f73bc91 
PR-URL: #10781
Reviewed-By: Jeremiah Senkpiel <[email protected]>
targos pushed a commit that referenced this pull request Jan 28, 2017
@iarna @targos
deps: upgrade npm to 4.1.1
1052513 
PR-URL: #10781
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@iarna @italoacasas
deps: upgrade npm to 4.1.1
1fae98b 
PR-URL: nodejs#10781
Reviewed-By: Jeremiah Senkpiel <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@iarna @italoacasas
deps: upgrade npm to 4.1.1
c1893ef 
PR-URL: nodejs#10781
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iarna @jasnell @Fishrock123 @nodejs-github-bot