Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-fs-write-stream-throw-type #10779

Closed
wants to merge 1 commit into from
Closed

test: improve test-fs-write-stream-throw-type #10779

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 13, 2017

  • validate the errors for all assert.throws
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@edsadr
test: improve test-fs-write-stream-throw-type
7856c73 
* validate the errors for all assert.throws
* use arrow functions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Jan 13, 2017
mhdawson
mhdawson approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5871/

jasnell pushed a commit that referenced this pull request Jan 16, 2017
@edsadr @jasnell
test: improve test-fs-write-stream-throw-type
1699a8a 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 16, 2017

Landed in 1699a8a

@jasnell jasnell closed this Jan 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: improve test-fs-write-stream-throw-type
50313d9 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@edsadr @italoacasas
test: improve test-fs-write-stream-throw-type
393dd5f 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@edsadr @italoacasas
test: improve test-fs-write-stream-throw-type
dcb5cc7 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@edsadr @italoacasas
test: improve test-fs-write-stream-throw-type
d818cfa 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edsadr @jasnell @cjihrig @mhdawson @mscdex @MylesBorins @nodejs-github-bot