Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test-icu-transcode if ICU is not present #10707

Closed
wants to merge 1 commit into from
+6 −1
Closed

test: skip test-icu-transcode if ICU is not present #10707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/parallel/test-icu-transcode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
'use strict';

require('../common');
const common = require('../common');
const buffer = require('buffer');
const assert = require('assert');

if (!common.hasIntl) {
Copy link
Member

@srl295 srl295 Jan 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use this for other test cases. 👍
This way we can easily find the test cases that are Intl dependent.

common.skip('icu punycode tests because ICU is not present.');
return;
}

const orig = Buffer.from('tést €', 'utf8');

// Test Transcoding
Expand Down