Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve the code in test-util-debug.js #10583

Closed
wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 3, 2017

  • use const and let instead of var
  • use assert.strictEqual instead of assert.equal
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 3, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Jan 3, 2017
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@italoacasas
Copy link
Contributor

the console.log() is part of the test functionality ?

@edsadr
Copy link
Member Author

edsadr commented Jan 3, 2017

@italoacasas that console.log is required, the test is spawning that function and asserting later the output, so if we remove the console log then we won't have anything to assert at the output ... but I removed another one that wasn't required in the same commit

@thefourtheye
Copy link
Contributor

There is already #10531

@edsadr
Copy link
Member Author

edsadr commented Jan 3, 2017

@thefourtheye .. right... I am closing this one if favor of #10531 and suggesting there to implement arrow functions to match mine

@edsadr edsadr closed this Jan 3, 2017
@edsadr edsadr deleted the util-debug branch January 3, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants