test: refactor test-tls-alert-handling #10482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
Trott
added
test
nodejs-github-bot
added
test
jasnell
approved these changes
Dec 28, 2016
targos
approved these changes
Dec 28, 2016
cjihrig
approved these changes
Dec 28, 2016
italoacasas
approved these changes
Dec 29, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 31, 2016
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: nodejs#10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
|
Landed in a6ca94a |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: #10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: #10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: #10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: #10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* process.on('exit',...) checks -> common.mustCall()
* remove unused function parameters
* var -> const/let
PR-URL: #10482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tls