build: enable debugger tests in CI #10456

thefourtheye · 2016-12-26T09:10:29Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

Description of change

Since #10361 is solved in master
branch, we can enable debugger tests in CI.

cc @nodejs/build

thefourtheye · 2016-12-26T19:01:08Z

CI Run: https://ci.nodejs.org/job/node-test-pull-request/5591/

cjihrig

LGTM in principle, but the CI still seems broken.

thefourtheye · 2016-12-26T19:15:24Z

@cjihrig I think #10455 would get rid of the TAP parsing failures. I'll work on it tomorrow.

Trott · 2016-12-27T05:00:25Z

Would there not be a corresponding change to make in vcbuild.bat?

richardlau · 2016-12-28T04:24:02Z

Makefile

@@ -123,8 +123,7 @@ v8:
 test: all
 	$(MAKE) build-addons
 	$(MAKE) cctest
-	$(PYTHON) tools/test.py --mode=release -J \
-		addons doctool inspector known_issues message pseudo-tty parallel sequential
+	$(PYTHON) tools/test.py --mode=release -J $(CI_JS_SUITES)


Also needs $(CI_NATIVE_SUITES) to include addons.

@richardlau I included that now. Can you please check if the batch file changes are okay?

thefourtheye · 2016-12-28T14:01:36Z

@Trott Oops, I totally forgot about that. I changed that as well now.

gibfahn · 2016-12-28T14:41:52Z

Makefile

@@ -200,11 +199,12 @@ test-all-valgrind: test-build
 	$(PYTHON) tools/test.py --mode=debug,release --valgrind

 CI_NATIVE_SUITES := addons
-CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential
+CI_JS_SUITES := addons debugger doctool inspector known_issues message \


I don't think addons should be here (it's already in CI_NATIVE_SUITES).

richardlau · 2016-12-28T17:41:51Z

vcbuild.bat

-if /i "%1"=="test"          set test_args=%test_args% addons doctool known_issues message parallel sequential -J&set jslint=1&set build_addons=1&goto arg-ok
-if /i "%1"=="test-ci"       set test_args=%test_args% %test_ci_args% -p tap --logfile test.tap addons doctool inspector known_issues message sequential parallel&set cctest_args=%cctest_args% --gtest_output=tap:cctest.tap&set build_addons=1&goto arg-ok
+if /i "%1"=="test"          set test_args=%test_args% %ci_test_targets% -J&set jslint=1&set build_addons=1&goto arg-ok
+if /i "%1"=="test-ci"       set test_args=%test_args% %test_ci_args% -p tap --logfile test.tap %ci_test_targets%&set cctest_args=%cctest_args% --gtest_output=tap:cctest.tap&set build_addons=1&goto arg-ok


I don't know the history here why test and test-ci were running different set of tests -- Anyone know why inspector tests weren't run for test before and if this change (which would include them) would cause any issues?

@nodejs/platform-windows, any idea?

I believe it was simply overlooked b4a249f cc @eugeneo

jasnell · 2016-12-29T19:38:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5625/

thefourtheye · 2017-01-02T12:46:47Z

CI Run: https://ci.nodejs.org/job/node-test-pull-request/5662/ (after landing #10455)

Trott · 2017-01-02T19:50:11Z

I think the only reason the debugger tests are in their own directory is because they are so fussy and unreliable. If we can't get the whole directory to be reliable on all platforms, maybe the thing to do instead of enable the debugger directory for tests is to move the ones that are now reliable to sequential or parallel?

Trott · 2017-01-02T20:15:52Z

Let's be careful with this one in CI. I could be wrong but it sure looks like the test failures here linger and hold onto ports that prevent subsequent CI runs from passing on AIX and FreeBSD. Shouldn't stop you from running CI, but maybe @-mention @nodejs/build and/or hop on #node-build on IRC if tests fails so someone can hop on the machines and terminate any stalled processes.

`process.title` would work properly only in FreeBSD, OSX, and Linux as per test/parallel/test-setproctitle.js. This patch makes sure that the test expects an empty string in other platforms. This patch helps fix the SmartOS failures in https://ci.nodejs.org/job/node-test-commit/6962/ for nodejs#10456

1. In Makefile, though CI and local test tests the same subsystems, CI target uses a variable and the local test enumerates the subsystems being tested. This patch makes both of them to use the same variable. 2. In vcbuild.bat, the inspector tests are not run when tested locally. This patch makes sure that they both use the same set of subsysterms set in a variable.

All the problems blocking nodejs#10361 have been resolved. This patch enables debugger in CI.

thefourtheye · 2017-01-30T16:33:16Z

New CI Run: https://ci.nodejs.org/job/node-test-pull-request/6106/ (after landing #10822)

`process.title` would work properly only in FreeBSD, OSX, and Linux as per test/parallel/test-setproctitle.js. This patch makes sure that the test expects an empty string in other platforms. This patch helps fix the SmartOS failures in https://ci.nodejs.org/job/node-test-commit/6962/ for nodejs#10456 PR-URL: nodejs#10597 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Evan Lucas <[email protected]>

joaocgreis · 2017-02-01T19:17:41Z

vcbuild.bat

@@ -39,6 +39,7 @@ set enable_vtune_arg=
 set configure_flags=
 set build_addons=
 set dll=
+set ci_test_targets="addons debugger doctool inspector known_issues message parallel sequential"


This will include the quotes in the variable. Open the quotes before the variable name instead:

set "ci_test_targets=addons debugger doctool inspector known_issues message parallel sequential"

`process.title` would work properly only in FreeBSD, OSX, and Linux as per test/parallel/test-setproctitle.js. This patch makes sure that the test expects an empty string in other platforms. This patch helps fix the SmartOS failures in https://ci.nodejs.org/job/node-test-commit/6962/ for nodejs#10456 PR-URL: nodejs#10597 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Evan Lucas <[email protected]>

`process.title` would work properly only in FreeBSD, OSX, and Linux as per test/parallel/test-setproctitle.js. This patch makes sure that the test expects an empty string in other platforms. This patch helps fix the SmartOS failures in https://ci.nodejs.org/job/node-test-commit/6962/ for #10456 PR-URL: #10597 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Evan Lucas <[email protected]>

jasnell · 2017-03-24T23:10:34Z

Ping. updates on this one?

bnoordhuis · 2017-03-26T10:06:35Z

I would suggest closing this. The tests in test/debugger are highly unreliable and we're phasing out the old debugger anyway. It doesn't make sense to sink a lot of time in getting them green.

thefourtheye requested review from MylesBorins and Trott December 26, 2016 09:10

nodejs-github-bot added build Issues and PRs related to build files or the CI. lts-watch-v6.x labels Dec 26, 2016

mscdex added debugger test Issues and PRs related to the tests. labels Dec 26, 2016

jasnell approved these changes Dec 26, 2016

View reviewed changes

cjihrig approved these changes Dec 26, 2016

View reviewed changes

richardlau reviewed Dec 28, 2016

View reviewed changes

thefourtheye mentioned this pull request Dec 28, 2016

test: refactor test-debugger-remote #10455

Closed

2 tasks

thefourtheye force-pushed the enable-debugger-tests branch from 5ff72fe to 263c036 Compare December 28, 2016 13:51

nodejs-github-bot added the lts-watch-v6.x label Dec 28, 2016

thefourtheye force-pushed the enable-debugger-tests branch from 263c036 to f894bca Compare December 28, 2016 13:56

nodejs-github-bot added the lts-watch-v6.x label Dec 28, 2016

gibfahn reviewed Dec 28, 2016

View reviewed changes

richardlau reviewed Dec 28, 2016

View reviewed changes

thefourtheye force-pushed the enable-debugger-tests branch from f894bca to 9595406 Compare December 28, 2016 18:03

nodejs-github-bot added the lts-watch-v6.x label Dec 28, 2016

jasnell closed this Dec 29, 2016

jasnell reopened this Dec 29, 2016

thefourtheye mentioned this pull request Jan 3, 2017

test: fix process.title expectation #10597

Closed

2 tasks

nodejs-github-bot added the lts-watch-v6.x label Jan 30, 2017

thefourtheye added 2 commits January 30, 2017 21:52

build: enable debugger tests in CI

e6b277c

All the problems blocking nodejs#10361 have been resolved. This patch enables debugger in CI.

thefourtheye force-pushed the enable-debugger-tests branch from d0f51f9 to e6b277c Compare January 30, 2017 16:30

nodejs-github-bot added the lts-watch-v6.x label Jan 30, 2017

joaocgreis reviewed Feb 1, 2017

View reviewed changes

jasnell added the stalled Issues and PRs that are stalled. label Mar 24, 2017

jasnell closed this Mar 26, 2017

thefourtheye deleted the enable-debugger-tests branch March 28, 2017 03:55

snyk-bot mentioned this pull request Apr 24, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#97

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#109

Open

This was referenced Apr 24, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#122

Open

[Snyk] Fix for 17 vulnerabilities aliscco/alisco-node#127

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#128

Open

This was referenced Apr 25, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#177

Open

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#182

Open

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#183

Open

aliscco mentioned this pull request Apr 26, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#195

Open

snyk-bot mentioned this pull request Apr 26, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#249

Open

aliscco mentioned this pull request Apr 28, 2023

[Snyk] Fix for 10 vulnerabilities aliscco/alisco-node#309

Open

snyk-bot mentioned this pull request Apr 28, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#336

Open

aliscco mentioned this pull request Apr 29, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#356

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: enable debugger tests in CI #10456

build: enable debugger tests in CI #10456

thefourtheye commented Dec 26, 2016 •

edited

Loading

thefourtheye commented Dec 26, 2016

cjihrig left a comment

thefourtheye commented Dec 26, 2016

Trott commented Dec 27, 2016

richardlau Dec 28, 2016

thefourtheye Dec 28, 2016

thefourtheye commented Dec 28, 2016

gibfahn Dec 28, 2016

thefourtheye Dec 28, 2016

richardlau Dec 28, 2016

thefourtheye Dec 28, 2016

thefourtheye Dec 28, 2016

jasnell commented Dec 29, 2016

thefourtheye commented Jan 2, 2017

Trott commented Jan 2, 2017

Trott commented Jan 2, 2017

thefourtheye commented Jan 30, 2017

joaocgreis Feb 1, 2017

jasnell commented Mar 24, 2017

bnoordhuis commented Mar 26, 2017

build: enable debugger tests in CI #10456

build: enable debugger tests in CI #10456

Conversation

thefourtheye commented Dec 26, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

thefourtheye commented Dec 26, 2016

cjihrig left a comment

Choose a reason for hiding this comment

thefourtheye commented Dec 26, 2016

Trott commented Dec 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thefourtheye commented Dec 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasnell commented Dec 29, 2016

thefourtheye commented Jan 2, 2017

Trott commented Jan 2, 2017

Trott commented Jan 2, 2017

thefourtheye commented Jan 30, 2017

Choose a reason for hiding this comment

jasnell commented Mar 24, 2017

bnoordhuis commented Mar 26, 2017

thefourtheye commented Dec 26, 2016 •

edited

Loading