-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test test-child-process-stdin.js: change assert.ok to assert.strictEqual #10418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sriluvan we have two assert.equal()
in line 37 and 39, would you mind updating those too?
Definitely. In another few minutes. |
@sriluvan sorry my bad, I see another PR with that changes #10022, why you don't make this changes in the original PR ? |
Ok. Didn't know I can update a open PR. will do it this time. |
Yes you can update your PR, add a commit with the changes in the same branch, squash and then use the |
I did like you suggested After commit executed this - Git push --force origin sriluvan Got message everything up-to-date Let me know if you don't see my changes |
I don't see your changes, the process should be: 1 - change to the branch |
Closing in favor of #10420 |
test test-child-process-stdin.js: change assert.ok to assert.strictEqual
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
Description of change