Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test test-child-process-stdin.js: change assert.ok to assert.strictEqual #10418

Closed
wants to merge 1 commit into from

Conversation

navulirs
Copy link
Contributor

test test-child-process-stdin.js: change assert.ok to assert.strictEqual

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 22, 2016
Copy link
Contributor

@italoacasas italoacasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriluvan we have two assert.equal() in line 37 and 39, would you mind updating those too?

@navulirs
Copy link
Contributor Author

Definitely. In another few minutes.

@italoacasas
Copy link
Contributor

@sriluvan sorry my bad, I see another PR with that changes #10022, why you don't make this changes in the original PR ?

@navulirs
Copy link
Contributor Author

Ok. Didn't know I can update a open PR. will do it this time.

@italoacasas
Copy link
Contributor

italoacasas commented Dec 23, 2016

Yes you can update your PR, add a commit with the changes in the same branch, squash and then use the --force flag, ask me if you have any question in the process

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 23, 2016
@navulirs
Copy link
Contributor Author

I did like you suggested

After commit executed this -

Git push --force origin sriluvan

Got message everything up-to-date

Let me know if you don't see my changes

@italoacasas
Copy link
Contributor

italoacasas commented Dec 23, 2016

I don't see your changes, the process should be:

1 - change to the branch test-fix -> PR #10022
2 - make this changes in that branch
3 - git add and git commit
4 - git push --force origin test-fix

@Trott
Copy link
Member

Trott commented Dec 24, 2016

Closing in favor of #10420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants