Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-https-timeout #10404

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-https-timeout #10404

wants to merge 1 commit into from
+11 −23

Commits on Dec 22, 2016

  1. test: fix flaky test-https-timeout 

    Remove `setTimeout()` in test and instead rely on `common.mustCall()` on
a `timeout` event handler.

The test was flaky on CI. The flakiness was replicable by running the
test under load. This version, in contrast, is robust under load.

Took the opportunity to do some `var` -> `const` while refactoring.
    @Trott
    Trott committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    2677dfc View commit details
    Browse the repository at this point in the history