buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

troy0820 · 2016-12-07T23:13:45Z

Removed unused variable conf from buffer-base64-decode.js and buffer-based64-encode.js

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Buffer

Description of change

Deleted variable that wasn't used which was conf

mscdex · 2016-12-08T00:14:43Z

I'm not sure it's worth removing. Benchmarks like this probably should have defined parameters containing defaults of at least the currently used values.

Trott · 2016-12-08T05:43:17Z

I'm not sure it's worth removing. Benchmarks like this probably should have defined parameters containing defaults of at least the currently used values.

@mscdex Does this mean you would endorse (or at least not object to) a change from this:

var bench = common.createBenchmark(main, {});

function main(conf) {
  var N = 64 * 1024 * 1024;
  var b = Buffer.allocUnsafe(N);
  var s = '';
  var i;
  for (i = 0; i < 256; ++i) s += String.fromCharCode(i);
  for (i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii');
  bench.start();
  for (i = 0; i < 32; ++i) b.toString('base64');
  bench.end(64);
}

...to something more like this?:

var bench = common.createBenchmark(main, {
  N: [64 * 1024 * 1024],
});

function main(conf) {
  var N = +conf.N;
  var b = Buffer.allocUnsafe(N);
  var s = '';
  var i;
  for (i = 0; i < 256; ++i) s += String.fromCharCode(i);
  for (i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii');
  bench.start();
  for (i = 0; i < 32; ++i) b.toString('base64');
  bench.end(64);
}

mscdex · 2016-12-08T07:30:43Z

@Trott Pretty much, although the iteration count might be configurable as well like with most other benchmarks.

troy0820 · 2016-12-08T14:48:48Z

@Trott @mscdex Do you want me to change the commit to the above snippet? I can make the changes and push the commit up to this branch.

mscdex · 2016-12-08T19:20:43Z

@troy0820 I think it would be better, yes. Just make sure to also add a parameter for the number of iterations (usually lowercase n).

Trott · 2016-12-08T19:40:11Z

number of iterations

@mscdex That would be the number of iterations in the loop between bench.start() and bench.end(), right? So, in the above example, it's 32? Also, would that value be passed to bench.end()? In the example above, 64 is hard-coded as what is sent to bench.end(), so...
¯\(ツ)/¯

mscdex · 2016-12-08T19:54:50Z

@Trott Correct. I don't know why 64 was being passed in the encode benchmark, it should be the loop count which is 32.

Trott · 2016-12-08T19:59:47Z

@troy0820 You up for making those changes as described above and trying to ascertain what the similar changes might be for the other file? (I'd guess just the iterations and nothing else in that file, but take a look and judge for yourself.)

troy0820 · 2016-12-08T20:01:23Z

@Trott Yeah I can make those changes. It sounds like it's the above snippet along with the only change being the 32 in the bench.end(32) function and adding then param to the main function.
Only question is do you want 32 to be in the bench.end() function or n?
I'll update the PR 👍

Trott · 2016-12-08T20:07:39Z

@troy0820 You'll want to add an n variable to the conf for both files and set it to 32. Then you'll want to assign it to a variable (like I did in the snippet with N) and use that variable in the loop and in bench.end(). Hit me up on IRC if this isn't clear, or just make a go at it and we'll iterate if it's not quite right.

troy0820 · 2016-12-08T21:37:51Z

Per discussion, adding an array to the createBenchmark object will allow the default buffer size to be included with the object and iteration in the loop. @mscdex @Trott

mscdex · 2016-12-08T21:52:08Z

benchmark/buffers/buffer-base64-encode.js

@@ -1,16 +1,20 @@
 'use strict';
 var common = require('../common.js');

-var bench = common.createBenchmark(main, {});
+const bench = common.createBenchmark(main, {
+  N: [64 * 1024 * 1024],


We might want to give this a better name to avoid confusion. I think other benchmarks use names like len, which I would be fine with.

mscdex · 2016-12-08T21:52:28Z

benchmark/buffers/buffer-base64-decode.js


 function main(conf) {
+  const n = conf.n;


This should be +conf.n.

mscdex · 2016-12-08T21:52:48Z

benchmark/buffers/buffer-base64-encode.js


 function main(conf) {
-  var N = 64 * 1024 * 1024;
+  var n = conf.n;
+  var N = conf.N;


Similarly for these, the values should be prefixed with + to ensure they are numbers.

mscdex · 2016-12-08T22:45:57Z

benchmark/buffers/buffer-base64-encode.js

@@ -3,15 +3,15 @@ var common = require('../common.js');

 const bench = common.createBenchmark(main, {
  N: [64 * 1024 * 1024],


Sorry, I meant this parameter should be called len. n should stay the same.

jasnell · 2016-12-23T04:11:59Z

benchmark/buffers/buffer-base64-encode.js

-  for (i = 0; i < 32; ++i) b.toString('base64');
-  bench.end(64);
+  for (i = 0; i < n; ++i) b.toString('base64');
+  bench.end(n);


Is the change from 64 to 32 in the bench.end(n) here intentional?

Nevermind... just spotted the other comment about it :-)

jasnell · 2016-12-23T04:13:04Z

Ping @mscdex

mscdex · 2016-12-23T04:36:53Z

benchmark/buffers/buffer-base64-encode.js

-  var b = Buffer.allocUnsafe(N);
-  var s = '';
-  var i;
+  const n = +conf.len;


This should be const n = +conf.n;

mscdex · 2016-12-23T04:37:21Z

benchmark/buffers/buffer-base64-encode.js

-  var s = '';
-  var i;
+  const n = +conf.len;
+  const N = +conf.N;


This should be const len = +conf.len;

mscdex · 2016-12-23T04:37:35Z

benchmark/buffers/buffer-base64-encode.js

-  var i;
+  const n = +conf.len;
+  const N = +conf.N;
+  const b = Buffer.allocUnsafe(N);


This should be const b = Buffer.allocUnsafe(len);

mscdex · 2016-12-23T04:37:54Z

benchmark/buffers/buffer-base64-encode.js

+  const N = +conf.N;
+  const b = Buffer.allocUnsafe(N);
+  let s = '';
+  let i;
  for (i = 0; i < 256; ++i) s += String.fromCharCode(i);
  for (i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii');


N here should be len

troy0820 · 2016-12-23T04:47:06Z

Rebased master and made changes @mscdex

mscdex · 2016-12-23T05:23:27Z

LGTM

Trott · 2016-12-23T18:25:16Z

Only relevant CI job for this is the linter, so here it is:

CI: https://ci.nodejs.org/job/node-test-linter/6010/

…on in buffer-base64-encode & buffer-base64-decode.js

Trott · 2016-12-23T19:37:41Z

Hmmm, the linter failed, but that might have been because it needed a rebase, which I just did. Let's try again...

CI: https://ci.nodejs.org/job/node-test-linter/6014/

Trott · 2016-12-23T19:39:19Z

Linter is ✅

Add configuration object createBenchmark object for buffer size & iteration in buffer-base64-encode & buffer-base64-decode.js. PR-URL: nodejs#10175 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>

Trott · 2016-12-23T19:51:08Z

Landed in 7021e6b.
Thanks for the contribution, @troy0820! 🎉

Add configuration object createBenchmark object for buffer size & iteration in buffer-base64-encode & buffer-base64-decode.js. PR-URL: #10175 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Dec 7, 2016

mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 8, 2016

troy0820 force-pushed the troy0820-code-and-learn branch from bb1f3b1 to a2af2c7 Compare December 8, 2016 21:36

mscdex reviewed Dec 8, 2016

View reviewed changes

troy0820 force-pushed the troy0820-code-and-learn branch 2 times, most recently from ac30244 to 3edffd5 Compare December 9, 2016 15:02

jasnell reviewed Dec 23, 2016

View reviewed changes

jasnell approved these changes Dec 23, 2016

View reviewed changes

mscdex reviewed Dec 23, 2016

View reviewed changes

troy0820 force-pushed the troy0820-code-and-learn branch from 3edffd5 to ad77d92 Compare December 23, 2016 04:44

nodejs-github-bot added the lts-watch-v6.x label Dec 23, 2016

troy0820 added 3 commits December 23, 2016 11:35

buffer: Add array in createBenchmark object for buffer size & iterati…

7243066

…on in buffer-base64-encode & buffer-base64-decode.js

buffer: Change n to len and added + to ensure it is a number

4eb18d6

buffer: Changed N to len and len back to n

df392f0

Trott force-pushed the troy0820-code-and-learn branch from ad77d92 to 8f096db Compare December 23, 2016 19:36

nodejs-github-bot added the lts-watch-v6.x label Dec 23, 2016

buffer: changed N to len and replaced all N to len

08cdc9c

Trott force-pushed the troy0820-code-and-learn branch from 8f096db to 08cdc9c Compare December 23, 2016 19:46

nodejs-github-bot added the lts-watch-v6.x label Dec 23, 2016

Trott closed this Dec 23, 2016

evanlucas mentioned this pull request Jan 3, 2017

v7.4.0 release proposal #10589

Merged

MylesBorins added dont-land-on-v4.x and removed lts-watch-v6.x labels Jan 23, 2017

MylesBorins mentioned this pull request Jan 24, 2017

v6.10.0 proposal #10974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

troy0820 commented Dec 7, 2016

mscdex commented Dec 8, 2016

Trott commented Dec 8, 2016 •

edited

Loading

mscdex commented Dec 8, 2016

troy0820 commented Dec 8, 2016

mscdex commented Dec 8, 2016

Trott commented Dec 8, 2016

mscdex commented Dec 8, 2016 •

edited

Loading

Trott commented Dec 8, 2016

troy0820 commented Dec 8, 2016 •

edited

Loading

Trott commented Dec 8, 2016

troy0820 commented Dec 8, 2016

mscdex Dec 8, 2016

mscdex Dec 8, 2016

mscdex Dec 8, 2016

mscdex Dec 8, 2016

jasnell Dec 23, 2016

jasnell Dec 23, 2016

jasnell commented Dec 23, 2016

mscdex Dec 23, 2016

mscdex Dec 23, 2016

mscdex Dec 23, 2016

mscdex Dec 23, 2016

troy0820 commented Dec 23, 2016

mscdex commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

		@@ -3,15 +3,15 @@ var common = require('../common.js');

		const bench = common.createBenchmark(main, {
		N: [64 * 1024 * 1024],

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

Conversation

troy0820 commented Dec 7, 2016

Checklist

Affected core subsystem(s)

Description of change

mscdex commented Dec 8, 2016

Trott commented Dec 8, 2016 • edited Loading

mscdex commented Dec 8, 2016

troy0820 commented Dec 8, 2016

mscdex commented Dec 8, 2016

Trott commented Dec 8, 2016

mscdex commented Dec 8, 2016 • edited Loading

Trott commented Dec 8, 2016

troy0820 commented Dec 8, 2016 • edited Loading

Trott commented Dec 8, 2016

troy0820 commented Dec 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasnell commented Dec 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

troy0820 commented Dec 23, 2016

mscdex commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 23, 2016

Trott commented Dec 8, 2016 •

edited

Loading

mscdex commented Dec 8, 2016 •

edited

Loading

troy0820 commented Dec 8, 2016 •

edited

Loading