Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update SSL/TLS version references #9822

Closed
mscdex opened this issue Nov 28, 2016 · 2 comments
Closed

doc: update SSL/TLS version references #9822

mscdex opened this issue Nov 28, 2016 · 2 comments
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 28, 2016

  • Version: v6.x+ ?
  • Platform: all
  • Subsystem: doc

Since node no longer supports SSLv3 (at least out of the box, not sure offhand about when using node with shared openssl), it is probably a good idea to remove references to SSLv3 in the tls documentation. For example:

  • The secureProtocol option examples in tls.connect() and tls.createServer() currently use SSLv3_method. We should probably change this to something like TLSv1_method. Also, it might be good to surround the name inside the backticks with single quotes since it is a string value.

  • tlsSocket.getProtocol() references SSLv3 as a valid example return value. If using a shared openssl does not change things, this should simply be removed from the list of example return values. The list of values should probably also include single quotes inside the backticks as well.

@mscdex mscdex added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Nov 28, 2016
@sam-github
Copy link
Contributor

Yep, and the tls.client example shouldn't claim to implement an "echo server" :-(. I'd like to move the entire example to the top of the TLS page, de-duplicate it, and provide a clearer description of what client authentication is, and how to enable it.

@mscdex mscdex changed the title doc: update TLS protocol version example doc: update SSL/TLS version references Nov 28, 2016
@Trott
Copy link
Member

Trott commented Jul 15, 2017

@nodejs/documentation

@BridgeAR BridgeAR added the crypto Issues and PRs related to the crypto subsystem. label Apr 22, 2018
jasnell added a commit to jasnell/node that referenced this issue Oct 19, 2018
@danbev danbev closed this as completed in d2fcd1d Oct 22, 2018
jasnell added a commit that referenced this issue Oct 22, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 26, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 26, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this issue Nov 28, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this issue Nov 28, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 29, 2018
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants