Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: intent to restructure README.md to be more advertising and introducing to docs #6920

Closed
eljefedelrodeodeljefe opened this issue May 21, 2016 · 19 comments
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@eljefedelrodeodeljefe
Copy link
Contributor

eljefedelrodeodeljefe commented May 21, 2016

Our README.md currently is quite technical - in terms of being useful for collaboration and security-wise(?).

I am convinced efforts moving towards the READE being more advertising and attractive to the reader is worthwhile.

Good examples that come to mind:

This would mean moving GPG stuff, maybe also the collaborator list, adding a logo etc.

@eljefedelrodeodeljefe eljefedelrodeodeljefe added the doc Issues and PRs related to the documentations. label May 21, 2016
@claudiorodriguez
Copy link
Contributor

+1, at the very least I suggest having an easily recognizable link to our docs in the readme's first fold

@eljefedelrodeodeljefe
Copy link
Contributor Author

For starters I could imagine something like:


README.md

IMAGE ALT TEXT HERE

IMAGE ALT TEXT HERE IMAGE ALT TEXT HERE

Node.js

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

@eljefedelrodeodeljefe
Copy link
Contributor Author

cc @nodejs/documentation @nodejs/website

@preco21
Copy link

preco21 commented May 24, 2016

What about big simbol on top of README.md?

As like: https://github.com/avajs/ava

@ghost
Copy link

ghost commented May 24, 2016

@preco21 yeah, that sounds like what @eljefedelrodeodeljefe suggested

@eljefedelrodeodeljefe
Copy link
Contributor Author

@preco21 I guess you mean before the h1-tag. This is the above. "README.md" just indicated what file we are in.

@eljefedelrodeodeljefe eljefedelrodeodeljefe added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label May 24, 2016
@silverwind
Copy link
Contributor

silverwind commented May 24, 2016

Where would those LTS and Docs buttons lead to? nevermind

By the way, If you're going with a logo, I'd say the h1 is redundant.

@ghost
Copy link

ghost commented May 24, 2016

@silverwind does markdown do alt attributes? i'm worried about accessibility

@silverwind
Copy link
Contributor

silverwind commented May 24, 2016

@tentakel yes, it does:

[![hi](http://res.cloudinary.com/jefe-io/image/upload/v1464098345/NodeJS_New_Pantone_owaqpk.png)](https://nodejs.org)    

hi

GitHub also supports a (very limited) set of HTML, but depending on where it's rendered, it might not get parsed correctly because HTML is a feature of Github-flavored markdown, e.g. non-standard.

<a href="https://nodejs.org">
  <img alt="hi" src="http://res.cloudinary.com/jefe-io/image/upload/v1464098345/NodeJS_New_Pantone_owaqpk.png"></img>
</a>
hi

@silverwind
Copy link
Contributor

Oh, and if we go with a logo, I'd really like to see a SVG (does a vector source file it exist?).

@eljefedelrodeodeljefe
Copy link
Contributor Author

@silverwind semantically I agree, I think though that the h1-tag gets to be honored in SEO really well (all structure tags tho.)

ACK svg

@eljefedelrodeodeljefe
Copy link
Contributor Author

Is there anyone with good design skills? maybe @mikeal for hooking up design people.

@preco21
Copy link

preco21 commented May 24, 2016

@eljefedelrodeodeljefe I mean, h1-tag as graphical logo with link.

@claudiorodriguez
Copy link
Contributor

There's this: https://commons.wikimedia.org/wiki/File:Node.js_logo.svg but the colors look a bit off

@kravelin
Copy link

Here's an SVG version of the logo, note I had to put it in a zip file as gitHub doesn't support uploading SVG files in the comments. I also tested using an svg image in a readme.md file and it didn't display on github, giving only the missing image icon so the svg may not be useful in this case and we'd have to use the png format.
logo-svg.zip

@lpinca
Copy link
Member

lpinca commented Mar 18, 2017

An SVG version of the logo is also available here https://nodejs.org/static/images/logo.svg thanks to @silverwind (nodejs/nodejs.org#884).

@silverwind
Copy link
Contributor

silverwind commented Mar 18, 2017

SVG works in READMEs, the light version should be more suitable in this case. I guess I can start on a PR. Do we want a horizontally centered logo, btw?

(I don't see @kravelin's version suitable, it's just a bitmap embedded in a SVG while mine is a proper scalable image)

@silverwind
Copy link
Contributor

Logo PR here: #12148

silverwind added a commit that referenced this issue Apr 2, 2017
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this issue Apr 10, 2017
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: nodejs#12148
Ref: nodejs#6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 18, 2017
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: nodejs/node#12148
Ref: nodejs/node#6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 31, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. (Or just make the changes to README and open a PR! :-D ) I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests

7 participants