-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: addon tests need more descriptive names than test.js #6651
Labels
test
Issues and PRs related to the tests.
Comments
Actually stringbytes-external-exceed-max has tests in the form |
#6653 for a potential fix. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
May 13, 2016
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: nodejs#6651 PR-URL: nodejs#6653 Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this issue
May 17, 2016
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: #6651 PR-URL: #6653 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
May 18, 2016
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: #6651 PR-URL: #6653 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
May 18, 2016
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: #6651 PR-URL: #6653 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When looking at test failures, the only way to identify which test failed is by the name. Unfortunately all the tests in the addons folder are called
test.js
, which leads to unhelpful output (see below).Currently it looks like there is only one test.js file in each folder in test/addons, so the simplest solution would be to name each test
$ADDON_NAME-test.js
. If that makes sense I can open a PR to do it.Sample output from the community CI
The text was updated successfully, but these errors were encountered: