Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: search indicators missing #6637

Closed
eljefedelrodeodeljefe opened this issue May 8, 2016 · 2 comments
Closed

doc: search indicators missing #6637

eljefedelrodeodeljefe opened this issue May 8, 2016 · 2 comments
Assignees
@silverwind
Labels
doc Issues and PRs related to the documentations.

Comments

@eljefedelrodeodeljefe
Copy link
Contributor

  • Version: all
  • Platform: all (likely, confirmed Safari, Chrome on OS X)
  • Subsystem: doc

As described in #6479 at the bottom, search indicators in browsers are missing which probably was unintentional:

Chrome (at least on a Mac) will give you indicators on the scrollbar of where cmd+f results are. Using custom styles on the scrollbar breaks this – so I'm glad to see it works again in the narrow view. However, in the wide view, since the content area's scrollbars are not on the body, they still don't work there:

ccaa3852-147a-11e6-95f7-92e3780fc599-1
Closed
1 task
@eljefedelrodeodeljefe eljefedelrodeodeljefe added the doc Issues and PRs related to the documentations. label May 8, 2016
@ChALkeR
Copy link
Member

ChALkeR commented May 8, 2016

This could be fixed by using position: fixed on the menu and making the right part the actual contents without a separate scrollbar, but using the body scrollbar instead

@silverwind
Copy link
Contributor

Sounds like soemthing like #5716 could fix this. I'll see if I can satisfy all cases.

@silverwind silverwind self-assigned this May 8, 2016
@silverwind silverwind mentioned this issue May 8, 2016
Closed
2 tasks
silverwind added a commit to silverwind/node that referenced this issue May 11, 2016
@silverwind
doc: fix issues related to page scrolling
15df52a 
Moved the sidebar to a fixed position and moved the positioning of the
main content to the page's body, which results in back/forward
navigation through hash links and search highlight working again.

Fixes: nodejs#6637
Based on: nodejs#5716
silverwind added a commit to silverwind/node that referenced this issue May 15, 2016
@silverwind
doc: fix issues related to page scrolling
f2630d2 
Moved the sidebar to a fixed position and moved the main column to the
page's body, which results in back/forward navigation through hash
links and search highlight working again.

Fixes: nodejs#6637
Fixes: nodejs#6751
Based on: nodejs#5716
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Lindstaedt <[email protected]>
MylesBorins pushed a commit that referenced this issue May 16, 2016
@silverwind
doc: fix issues related to page scrolling
06854f1 
Moved the sidebar to a fixed position and moved the main column to the
page's body, which results in back/forward navigation through hash
links and search highlight working again.

Fixes: #6637
Fixes: #6751
Based on: #5716
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Lindstaedt <[email protected]>
evanlucas pushed a commit that referenced this issue May 17, 2016
@silverwind @evanlucas
doc: fix issues related to page scrolling
4f2a55f 
Moved the sidebar to a fixed position and moved the main column to the
page's body, which results in back/forward navigation through hash
links and search highlight working again.

Fixes: #6637
Fixes: #6751
Based on: #5716
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Lindstaedt <[email protected]>
MylesBorins pushed a commit that referenced this issue May 18, 2016
@silverwind
doc: fix issues related to page scrolling
126fdc3 
Moved the sidebar to a fixed position and moved the main column to the
page's body, which results in back/forward navigation through hash
links and search highlight working again.

Fixes: #6637
Fixes: #6751
Based on: #5716
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Lindstaedt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silverwind silverwind

Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix issues related to page scrolling silverwind/node
3 participants
@silverwind @ChALkeR @eljefedelrodeodeljefe