Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fs.appendFileSync wrong file argument type #6508

Closed
MrQubo opened this issue May 1, 2016 · 2 comments
Closed

doc: fs.appendFileSync wrong file argument type #6508

MrQubo opened this issue May 1, 2016 · 2 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Comments

@MrQubo
Copy link

MrQubo commented May 1, 2016 •
edited by thefourtheye
Loading

Documentation says that fs.appendFileSync(file, data[, options]) accepts String or Buffer as file, but it accepts file descriptor too.

fs.appendFileSync(file, data[, options]) documentation: https://nodejs.org/dist/latest-v6.x/docs/api/fs.html#fs_fs_appendfilesync_file_data_options
@addaleax addaleax added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 1, 2016
@addaleax
Copy link
Member

addaleax commented May 1, 2016

@MrQubo You don’t happen to be interested in changing the docs for these things yourself? That would definitely be appreciated! In any case, thank you for pointing out these issues.

@fhalde fhalde mentioned this issue May 12, 2016
Closed
2 tasks
fhalde added a commit to fhalde/node that referenced this issue May 12, 2016
@fhalde
doc: appendFileSync accepts fd as well
293e706 
Refer: nodejs#6508
jasnell pushed a commit that referenced this issue May 13, 2016
@fhalde @jasnell
doc: appendFileSync accepts fd as well
fc96fda 
Refs: #6508
PR-URL: #6707
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@thefourtheye
Copy link
Contributor

thefourtheye commented May 14, 2016 •
edited
Loading

Fixed by fc96fda

evanlucas pushed a commit that referenced this issue May 17, 2016
@fhalde @evanlucas
doc: appendFileSync accepts fd as well
64fcba2 
Refs: #6508
PR-URL: #6707
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thefourtheye @addaleax @MrQubo