Allow http2 server to be configured with ALPNCallback #55994
Labels
feature request
Issues that request new features to be added to Node.js.
http2
Issues or PRs related to the http2 subsystem.
Comments
Y3RmKHgp
added
the
feature request
github-project-automation
bot
moved this to Awaiting Triage
in Node.js feature requests
targos
pushed a commit
that referenced
this issue
Dec 13, 2024
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Dec 20, 2024
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Jan 5, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
Jan 22, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
Jan 22, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
Jan 22, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
Jan 23, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
Jan 24, 2025
PR-URL: #56187 Fixes: #55994 Refs: #45190 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the problem this feature will solve?
Currently, the http2 server always sets the ALPNProtocols field on the TLSServer options, which makes it incompatible with the ALPNCallback option.
Fixing this allows an http2 server with custom ALPN processing to be possible. For example, this allows the server to dynamically allow or deny http2 support based on the SNI.
What is the feature you are proposing to solve the problem?
Patch lib/internal/http2/core.js to avoid setting ALPNProtocols if ALPNCallback is present.
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: