Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Missing version info for TextEncoder.prototype.encodeInto() #55938

Closed
skyclouds2001 opened this issue Nov 20, 2024 · 0 comments · Fixed by #55990
Closed

doc: Missing version info for TextEncoder.prototype.encodeInto() #55938

skyclouds2001 opened this issue Nov 20, 2024 · 0 comments · Fixed by #55990
Labels
doc Issues and PRs related to the documentations.

Comments

@skyclouds2001
Copy link
Contributor

skyclouds2001 commented Nov 20, 2024 •
edited
Loading

Affected URL(s)

https://nodejs.org/docs/latest/api/util.html

Description of the problem

per #29524 and https://nodejs.org/en/blog/release/v12.11.0/, it shipped in v12.11.0/, but currently not documented (if inherit from the interface, it'll be v8.3.0, which is not true)

also, there is a version mismatch for TextDecoder, the v11.0.0 The class is now available on the global object. item should add on the interface, not the constructor

also see #13644 and https://nodejs.org/en/blog/release/v8.3.0/ for the API's initial implement

target links:
https://nodejs.org/docs/latest/api/util.html#class-utiltextdecoder
https://nodejs.org/docs/latest/api/util.html#class-utiltextencoder
@skyclouds2001 skyclouds2001 added the doc Issues and PRs related to the documentations. label Nov 20, 2024
@skyclouds2001 skyclouds2001 changed the title doc: Missing version info for TextEncoder..prototype.encodeInto() doc: Missing version info for TextEncoder.prototype.encodeInto() Nov 20, 2024
lpinca added a commit to lpinca/node that referenced this issue Nov 25, 2024
@lpinca
doc: add history entry for textEncoder.encodeInto()
a9b3c4f 
Fixes: nodejs#55938
@lpinca lpinca mentioned this issue Nov 25, 2024
Merged
lpinca added a commit to lpinca/node that referenced this issue Nov 25, 2024
@lpinca
doc: move history entry to class description
895a5ce 
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
@lpinca lpinca mentioned this issue Nov 25, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Nov 27, 2024
@lpinca
doc: move history entry to class description
db8ff56 
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: #55938
PR-URL: #55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add history entry for textEncoder.encodeInto() lpinca/node
1 participant
@skyclouds2001