Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong position of the zlib.crc32 section #55800

Closed
ijisol opened this issue Nov 9, 2024 · 4 comments
Closed

Wrong position of the zlib.crc32 section #55800

ijisol opened this issue Nov 9, 2024 · 4 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@ijisol
Copy link

ijisol commented Nov 9, 2024

Affected URL(s)

https://nodejs.org/api/zlib.html#zlibcrc32data-value

Description of the problem

node/lib/zlib.js

Line 848 in e225f00

crc32,

The crc32 is not a method of ZlibBase. It is a standalone function of the module.
@ijisol ijisol added the doc Issues and PRs related to the documentations. label Nov 9, 2024
@avivkeller
Copy link
Member

PRs are welcome!

@ijisol
Copy link
Author

ijisol commented Nov 9, 2024

@redyetidev I would like to if I could, but to be honest, I don't know how to do it. 😅

@ijisol ijisol closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
@ijisol ijisol reopened this Nov 9, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 11, 2024

It's a matter of modifying doc/api/zlib.md.

@kevinuehara kevinuehara mentioned this issue Nov 16, 2024
Closed
@kevinuehara
Copy link
Contributor

Updated in this PR: #55887

@kevinuehara kevinuehara mentioned this issue Nov 17, 2024
Merged
@aduh95 aduh95 closed this as completed in bd0b704 Dec 24, 2024
aduh95 pushed a commit that referenced this issue Jan 2, 2025
@kevinuehara @aduh95
doc: fix the crc32 documentation
3943986 
PR-URL: #55898
Fixes: #55800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aduh95 @kevinuehara @avivkeller @ijisol