Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing documentaion for PerformanceObserver.prototype.takeRecords() of perf_hooks module #55779

Closed
skyclouds2001 opened this issue Nov 8, 2024 · 1 comment · Fixed by #55786
Closed

Missing documentaion for PerformanceObserver.prototype.takeRecords() of perf_hooks module #55779

skyclouds2001 opened this issue Nov 8, 2024 · 1 comment · Fixed by #55786
Labels
doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@skyclouds2001
Copy link
Contributor

skyclouds2001 commented Nov 8, 2024 •
edited
Loading

Affected URL(s)

https://nodejs.org/docs/latest/api/perf_hooks.html

Description of the problem

node.js support this method in v16.0.0 but not documentated

confirmed by the release and impl pr

also confirmed in local node.js v22

image
@skyclouds2001 skyclouds2001 added the doc Issues and PRs related to the documentations. label Nov 8, 2024
@skyclouds2001 skyclouds2001 changed the title Missing documentaion for PerformanceObserver.takeRecords() of perf_hooks module Missing documentaion for PerformanceObserver.prototype.takeRecords() of perf_hooks module Nov 8, 2024
@RedYetiDev
Copy link
Member

PRs are always welcome!

@RedYetiDev RedYetiDev added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Nov 8, 2024
@skyclouds2001 skyclouds2001 mentioned this issue Nov 8, 2024
Merged
skyclouds2001 added a commit to skyclouds2001/node that referenced this issue Nov 8, 2024
@skyclouds2001
doc: add doc for PerformanceObserver.takeRecords()
04c1d1f 
Fixes: nodejs#55779
skyclouds2001 added a commit to skyclouds2001/node that referenced this issue Nov 14, 2024
@skyclouds2001
doc: add doc for PerformanceObserver.takeRecords()
0624b37 
Fixes: nodejs#55779
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
@skyclouds2001 @Ceres6
doc: add doc for PerformanceObserver.takeRecords()
5c952f3 
PR-URL: nodejs#55786
Fixes: nodejs#55779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit that referenced this issue Nov 26, 2024
@skyclouds2001 @aduh95
doc: add doc for PerformanceObserver.takeRecords()
a3f7db6 
PR-URL: #55786
Fixes: #55779
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add missing documentation for PerformanceObserver.prototype.takeRecords() skyclouds2001/node
2 participants
@RedYetiDev @skyclouds2001