Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to libuv 1.44.2 broke OS=="android" build due to missing source file 'src/unix/android-ifaddrs.c' #46744

Closed
nappy opened this issue Feb 20, 2023 · 0 comments · Fixed by #46746
Closed

Upgrade to libuv 1.44.2 broke OS=="android" build due to missing source file 'src/unix/android-ifaddrs.c' #46744

nappy opened this issue Feb 20, 2023 · 0 comments · Fixed by #46746

Comments

@nappy
Copy link
Contributor

nappy commented Feb 20, 2023 •
edited
Loading

The file src/unix/android-ifaddrs.c was deleted here: c9c958e
but is still required by

node/deps/uv/uv.gyp

Line 259 in 1d5058d

'src/unix/android-ifaddrs.c',

@lpinca
nappy added a commit to nappy/node that referenced this issue Feb 20, 2023
@nappy
deps: fix libuv for android
b738cae 
Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: nodejs#46743
Fixes: nodejs#46744
This was referenced Feb 20, 2023
Closed
Merged
nappy added a commit to nappy/node that referenced this issue Feb 21, 2023
@nappy
deps: fix libuv for android
a963899 
Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: nodejs#46743
Fixes: nodejs#46744
nodejs-github-bot pushed a commit that referenced this issue Feb 22, 2023
@nappy
deps: fix libuv for android
ee22706 
Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: #46743
Fixes: #46744
PR-URL: #46746
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this issue Mar 13, 2023
@nappy @targos
deps: fix libuv for android
d9069e7 
Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: #46743
Fixes: #46744
PR-URL: #46746
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 11, 2023
@nappy @danielleadams
deps: fix libuv for android
2b439a2 
Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: #46743
Fixes: #46744
PR-URL: #46746
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: fix libuv for android nappy/node
deps: fix libuv for android nappy/node
1 participant
@nappy