-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector.url()/open() does not work if NODE_V8_COVERAGE is set #46110
Comments
a workaround (until it is fixed) is adding |
Unfortunately in my case, the subprocess with |
nodejs-github-bot
pushed a commit
that referenced
this issue
Jan 29, 2023
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Feb 1, 2023
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
Mar 3, 2023
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
Mar 3, 2023
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
Mar 5, 2023
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v19.3.0
Platform
Darwin MacBook-Pro-2.guest.corp.microsoft.com 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64
Subsystem
inspector
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
100%
What is the expected behavior?
I would expect, regardless of whether
NODE_V8_COVERAGE
is set, to be able toinspector.open()
if there is noinspector.url()
, and then after calling that be able to accessinspector.url()
What do you see instead?
If NODE_V8_COVERAGE is set,
inspector.url()
is undefined butinspector.open()
throws an error.Additional information
Originally reported on microsoft/vscode-js-debug#1507
It looks like
new inspector.Session().connect()
does still work in case, so we could 'fake' the inspect server as a workaround, but this is a complex hack.The text was updated successfully, but these errors were encountered: