Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document return value of http.server.listen #4571

Closed
crandmck opened this issue Jan 7, 2016 · 0 comments
Closed

Document return value of http.server.listen #4571

crandmck opened this issue Jan 7, 2016 · 0 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@crandmck
Copy link

crandmck commented Jan 7, 2016

As noted in expressjs/expressjs.com#539, docs don't specify the return value of http.server.listen but it does appear return an http.Server object.

I'd add a PR, but I'm not sure if the return value is the same for all flavors (i.e. signatures) of the function.
@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Jan 7, 2016
@Sequoia Sequoia mentioned this issue Jan 8, 2016
Closed
Sequoia added a commit to Sequoia/node that referenced this issue Jan 8, 2016
@Sequoia
doc: document server.listen return value
432aced 
The server method returns `self` in order to
allow chaining.

closes nodejs#4571
@Sequoia Sequoia mentioned this issue Jan 8, 2016
Closed
MylesBorins pushed a commit that referenced this issue Jan 11, 2016
@Sequoia
doc: document http's server.listen return value
749aaa7 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 12, 2016
@Sequoia
doc: document http's server.listen return value
b181e26 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 13, 2016
@Sequoia
doc: document http's server.listen return value
80ad952 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 14, 2016
@Sequoia
doc: document http's server.listen return value
bb3af99 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 14, 2016
@Sequoia
doc: document http's server.listen return value
19f21ab 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@Sequoia
doc: document http's server.listen return value
5b45a46 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Sequoia
doc: document http's server.listen return value
e42869f 
The server method returns `self` in order to allow chaining.

PR-URL: nodejs#4590
Fixes: nodejs#4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document server.listen return val Sequoia/node
2 participants
@mscdex @crandmck