-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: supported or should a userland module be used #4532
Comments
stable and locked doesn't mean "good for all purposes". I think the statement should be qualified to add "For the purposes of unit testing, it is recommended that a userland unit test library be used instead." Apparently some people think that the assert lib is for unit testing, and then complain about missing features. While it is used for unit testing in node... that is unusual, its mostly for in-source assertion of invariants. |
+1 to what @sam-github said. |
Could be a little stronger:
|
Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: nodejs#4532 PR-URL: nodejs#4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
In the docs at https://nodejs.org/api/assert.html it states:
Is this still a valid statement, or should we remove this line as the assert module is marked as stable and locked?
The text was updated successfully, but these errors were encountered: