Reduce the number of patches we float on V8 #45118
Comments
targos
added
help wanted
I know this. I send the patch, but v8 team want it to be compatible with cpp20, so it got stuck |
|
"make V8 compilable with older glibc" can be dropped, "silence irrelevant V8 warning" can be dropped if we turn off W.r.t. the msvc patches: maybe we should just switch to clang-cl? We'll want V8's headers to be usable by msvc (for add-ons) but that's a lot less work than keeping V8 itself buildable under msvc. |
Let me rebase #35433 to see how it goes. |
|
/cc @richardlau who added |
fcc183c was a follow on to #32685 where the original request to enable |
|
In terms of -Werror, is the suggestion to turn it off just for V8 or for all of Node.js. I'd be ok with turning it off for deps like v8, but would want us to keep it for our code. |
This reverts commit 01bc8e6. PR-URL: #45119 Refs: #45118 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
I'm all for it, but I don't know how to set that up. |
For dependencies, like V8, since we don't control those.
|
|
I've reminded myself of how we set this up -- we already only turn on (in the CI through the |
This reverts commit 84d455e. PR-URL: #45162 Refs: #45118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
@Flarna It's not obvious what your edit changed (apart from removing the first check) |
|
Actually I didn't want to change anything. Whatever was done by me here was per accident. Sorry |
This reverts commit 01bc8e6. PR-URL: #45119 Refs: #45118 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This reverts commit 84d455e. PR-URL: #45162 Refs: #45118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
This reverts commit 01bc8e6. PR-URL: #45119 Refs: #45118 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This reverts commit 84d455e. PR-URL: #45162 Refs: #45118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
I will give another try after MSVC fix landed #45427 (comment) |
|
(That whole class of compile-time trouble is likely going away now.) |
We should aim for 0 floating patches from our side (except cherry-picks of commits that landed upstream).
Here's the list of everything that we currently float on top of V8 10.7:
I don't remember why we have this one. It's quite old, so I opened a PR trying to revert it.
This bundles 4 fixes related to inline methods with Windows/MSVC. I think we would actually need a 5th one to fix the MSVC build with Visual Studio 2022 (windows build start failed on main caused by MSVC update #43092).
Ideally we would upstream the necessary fixes but I don't know enough of C++/Windows to open a CL that the V8 team would accept.
Not sure why this wasn't submitted upstream.
Revert tentative: deps: V8: add explicit constructor to CppHeapCreateParams #45700
Now fixed upstream in https://chromium-review.googlesource.com/c/v8/v8/+/3533019
Can we remove this one now? PR: Revert "deps: make V8 compilable with older glibc" #45162
I often have to do this kind of patches. The problem is that if we keep the deprecation, V8's own headers trigger it and the build fails because of
-Werror. There's probably a better way to handle it but I don't know it.Still waiting for SmartOS people to upstream the fix. (Build error on SmartOS node-v8#239)
Fixed upstream in https://chromium-review.googlesource.com/c/v8/v8/+/4026402
Don't know what do to about this one. See discussion in Build error on Windows node-v8#235
@nodejs/v8-update
The text was updated successfully, but these errors were encountered: