-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check failed: result.second #43617
Comments
Thanks for the bug report. This is indeed different from #32463. I'm fairly sure it's a bug in the version of V8 that ships with node v16.x. v18.x should be unaffected because it ships with a newer version of V8 where it's fixed. For reference: the fix is v8/v8@fcdf35e but that commit can't be back-ported because it sits on top of a bigger, backwards incompatible change, v8/v8@578f6be. That second commit isn't a problem for node (it doesn't use those APIs) but it has the potential to break native modules. Out of curiosity, does |
Thanks for replying @bnoordhuis. I give you result that prints out of this command
Even though It was fixed in v8/v8@fcdf35e, but we still got these errors. Hope see to see your new reply. Thanks. |
You're using v16.x, right? The fix isn't in any v16.x release. Try removing those two modules (canvas and node-sass) if possible. Although it's a V8 bug, they may be making it worse. |
Yes, I am using v16, I will try to use your solution and give you feedback. Thanks @bnoordhuis |
Hi @bnoordhuis .
|
Hi @bnoordhuis . Is there anything that I can give you? Thanks @bnoordhuis |
As expectation management: I don't know if this can be fixed in v16. I can't reproduce the bug myself, there is nothing that stands out when reading the relevant code in in node and V8, and there isn't a simple fix that can be back-ported from newer versions. |
I believe this is fixed in #42874, which should be available in the next Node 16 release. |
Hi @tony19 We have two kinds of errors Error 1: FATAL ERROR: v8::FromJust Maybe value is Nothing. Error 2: # # Fatal error in , line 0 # Check failed: result.second. # # # #FailureMessage Object: 00000021734FDF90 Which one was fixed? or both of them ? |
@Ram4GB I think the fix addresses the root problem that caused both of those errors. We'll have to test that once it gets released. |
Hi @tony19 Did you test your code with the latest Node version (v16.17.0)? For me, I tested and cannot reproduce this bug for running code 20 times. I hope you will get a great result like me. Cheer 🎉 |
FYI, Vitest 0.22.0 (released yesterday) now has a retry mechanism that checks for this specific segfault (and a couple others). |
Oh I have seen it, it's really great config. Thank for your ideas and supporting 😄. @tony19 |
Hi @tony19 I checked your ci, does it pass or cancel? |
It timed out on the 20th test run in Windows, but it effectively passed, as no segfaults occurred in any Node 16 jobs. Looks like the fix works! |
Ok now we will close this issue. Upgrade to the latest version (v16.17.0) to fixed Thanks everyone.🎉 🎉 🎉. |
- nodejs/node#43617 Signed-off-by: Lexus Drumgold <[email protected]>
- nodejs/node#43617 Signed-off-by: Lexus Drumgold <[email protected]>
Version
v16.15.1
Platform
Microsoft Windows NT 10.0.22000.0 x64
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
I run test 10 times, but It just fails 2 times and show up errors on my terminal.
What is the expected behavior?
The Vitest's test cases was passed
What do you see instead?
This is some images which contains the issue conducted by me and my teammate.
I can give some example errors here
Example 1: On mac
Example 2: On mac
Example 3:
Example 4:
Example 5:
Example 6:
Additional information
Check failed: !holder_map.has_named_interceptor().
when runningjest
#40030](Check failed: !holder_map.has_named_interceptor(). when running jest)The text was updated successfully, but these errors were encountered: