Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subprocess.kill should ignore signal argument on Windows #42923

Closed
fasttime opened this issue Apr 29, 2022 · 1 comment · Fixed by #55514
Closed

subprocess.kill should ignore signal argument on Windows #42923

fasttime opened this issue Apr 29, 2022 · 1 comment · Fixed by #55514
Labels
child_process Issues and PRs related to the child_process subsystem. windows Issues and PRs related to the Windows platform.

Comments

@fasttime
Copy link
Contributor

fasttime commented Apr 29, 2022

Version

v18.0.0

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

child_process

What steps will reproduce the bug?

The documentation about subprocess.kill([signal]) says:

On Windows, where POSIX signals do not exist, the signal argument will be
ignored, and the process will be killed forcefully and abruptly (similar to
'SIGKILL').

This does not seem to match the current behavior, where the signal argument is not ignored on Windows, and it can lead in fact to different results. A minimal repro:

// test.mjs - Run on Windows

import { spawn } from 'child_process';

spawn(process.execPath, ['-v']).kill('SIGKILL'); // ok
spawn(process.execPath, ['-v']).kill('SIGHUP'); // throws ENOSYS

How often does it reproduce? Is there a required condition?

Always on Windows

What is the expected behavior?

If the documentation is right, invoking kill('SIGHUP') on a subprocess on Windows should work exactly like kill('SIGKILL').

What do you see instead?

The signal argument is not currently ignored on Windows. I can't decide if this behavior is intended and the documentation is wrong or if the documentation is right and the behavior is incorrect.

Additional information

If someone could clarify me about the expectations of running subprocess.kill on Windows, I would be glad to submit a PR to fix the code or the documentation.

@VoltrexKeyva VoltrexKeyva added child_process Issues and PRs related to the child_process subsystem. windows Issues and PRs related to the Windows platform. labels Apr 30, 2022
@fabiospampinato
Copy link

This seems a fairly significant issue, in the sense that anybody that is triggering a signal with process.kill without knowing this issue is probably doing it in a problematic way for Windows.

huseyinacacak-janea added a commit to JaneaSystems/node that referenced this issue Oct 24, 2024
nodejs-github-bot pushed a commit that referenced this issue Nov 20, 2024
Fixes: #42923
PR-URL: #55514
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
Fixes: nodejs#42923
PR-URL: nodejs#55514
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
Fixes: nodejs#42923
PR-URL: nodejs#55514
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
aduh95 pushed a commit that referenced this issue Nov 26, 2024
Fixes: #42923
PR-URL: #55514
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants