-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: parallel/test-https-agent-unref-socket requires external network connection #39008
Comments
AdamMajer
added a commit
to AdamMajer/node
that referenced
this issue
Jun 11, 2021
AdamMajer
added a commit
to AdamMajer/node
that referenced
this issue
Jun 14, 2021
targos
pushed a commit
that referenced
this issue
Jul 11, 2021
Fixes: #39008 PR-URL: #39011 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
This fix is missing on Node.js 14 branch, causing test failure if running make test on system w/o internet connection:
How do I request backporting the fix to 14.x branch? |
targos
pushed a commit
that referenced
this issue
Sep 4, 2021
Fixes: #39008 PR-URL: #39011 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
Commit 4e33532 introduced a network fragile test which fails when there is no network available,
The text was updated successfully, but these errors were encountered: