Windows build fails with Visual Studio 2019 v16.10

[targos]

Released last week: https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#16.10.0
This affects GitHub actions as they updated today: actions/runner-images#3452

Run ./vcbuild.bat
Looking for Python
Python found in C:\hostedtoolcache\windows\Python\3.9.5\x64\\python.exe
Looking for NASM
Looking for Visual Studio 2019
calling: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.10.0
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 16.0
configure  --dest-cpu=x64
Node.js configure: Found Python 3.9.5...
Warning: Missing input files:
D:\a\node\node\tools\msvs\genfiles\node_etw_provider.rc
D:\a\node\node\tools\msvs\genfiles\node_etw_provider.h
INFO: configure completed successfully
Project files generated.
D:\a\node\node\deps\histogram\histogram.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\node_etw.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\uvwasi\uvwasi.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\v8_libplatform.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\zlib\zlib.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\llhttp\llhttp.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\cares\cares.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\uv\libuv.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\nghttp2\nghttp2.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\brotli\brotli.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\openssl\openssl.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\ngtcp2\ngtcp2.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\deps\ngtcp2\nghttp3.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\icu\icu_implementation.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\icu\icu_uconfig.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\icu\icu_uconfig_target.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\cppgc_base.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\v8_libsampler.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\v8_version.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\v8_cppgc_shared.vcxproj : error MSB4057: The target "node" does not exist in the project.
D:\a\node\node\tools\v8_gypfiles\v8_zlib.vcxproj : error MSB4057: The target "node" does not exist in the project.

/cc @nodejs/platform-windows

[targos]

I'm not 100% certain it is because of VS 16.10, as I didn't try to build on the same commit (16ae378) with the previous version...
@jasnell do you still have VS 16.9 or earlier? Can you confirm that it works with it?

[targos]

FWIW, I can load node.sln without any issues in the Visual Studio GUI, and build histogram, uvwasi, etc...

[targos]

This is probably the relevant part of vcbuild.bat:

node/vcbuild.bat

Lines 331 to 343 in 16ae378

	if "%target%"=="Build" (
	if defined no_cctest set target=node
	if "%test_args%"=="" set target=node
	if defined cctest set target="Build"
	)
	if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
	if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
	@rem Setup env variables to use multiprocessor build
	set UseMultiToolTask=True
	set EnforceProcessCountAcrossBuilds=True
	set MultiProcMaxCount=%NUMBER_OF_PROCESSORS%
	msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args%
	if errorlevel 1 (

[targos]

I don't know what target=node is supposed to do. I forced line 342 to the following and am doing a build:

msbuild node.sln %msbcpu% /t:Build /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args%

[targos]

Well, the above works, but target=node was added to speed up the build, so I don't know exactly what to do now...

Refs: 8514ea9

[targos]

It's actually a known issue in MSBuild 16.10.0 !

https://github.com/dotnet/msbuild/releases/tag/v16.10.0
dotnet/msbuild#6373
dotnet/msbuild#6465

If I understand correctly, this will be fixed in v16.10.1.

[jasnell]

Nice to know. I'm still on 16.9 and was thinking about updating. I guess I'll wait!