-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Clarify support for allowHalfOpen
option for IPC connections
#38307
Comments
lpinca
added a commit
to lpinca/node
that referenced
this issue
Apr 22, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. Fixes: nodejs#38307
lpinca
added a commit
to lpinca/node
that referenced
this issue
Apr 22, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. Fixes: nodejs#38307
targos
pushed a commit
that referenced
this issue
Apr 29, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. PR-URL: #38360 Fixes: #38307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this issue
May 30, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. PR-URL: #38360 Fixes: #38307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this issue
Jun 5, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. PR-URL: #38360 Fixes: #38307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this issue
Jun 5, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. PR-URL: #38360 Fixes: #38307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this issue
Jun 11, 2021
The `allowHalfOpen` option works in the same way for both TCP and IPC connections. PR-URL: #38360 Fixes: #38307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📗 API Reference Docs Problem
Location
Section of the site where the content exists
Affected URL(s):
Description
Concise explanation of the problem
The documentation on
allowHalfOpen
states:It explicitly mentions TCP, but I tried on an IPC connection with Unix Domain Socket and the option also seems to work as expected.
Should the doc be updated to either drop the explicit TCP mention or clarify expectations wrt IPC connections?
The text was updated successfully, but these errors were encountered: