-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker exits with code 0 (and not 7) when throwing inside uncaughtException #37996
Labels
Comments
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 31, 2021
Change worker exit code when the unhandled exception handler throws from 0 to 7 fixes: nodejs#37996
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 31, 2021
Change worker exit code when the unhandled exception handler throws from 0 to 7 fixes: nodejs#37996
targos
pushed a commit
that referenced
this issue
May 1, 2021
Change worker exit code when the unhandled exception handler throws from 0 to 7 fixes: #37996 PR-URL: #38012 Fixes: #37996 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is the underlying bug that kept my workaround of #37988 from working.
What steps will reproduce the bug?
index.js
worker.js
How often does it reproduce? Is there a required condition?
10/10 would reproduce again
What is the expected behavior?
Exit code7
for the workerExit code
>0
for the worker. Exit codes of workers don't seem to be aligned with the main process, I'm fine with anything other than 0.What do you see instead?
Exit code
0
, which is why my error handling didn't catch itThe text was updated successfully, but these errors were encountered: