-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values for --unhandled-rejection flag added in v15 are not in --help (and default value is not indicated) #37896
Comments
Maybe we could reuse the wording in the documentation: https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode |
There's not gonna be a three-word explanation of
|
These values were added in v15.0.0 by nodejs#33475 but were not included in the `node --help` output. Also document which value is the default. Fixes nodejs#37896.
Thanks. I've filed #37899 with @dfabulich's text. |
These values were added in v15.0.0 by nodejs#33475 but were not included in the `node --help` output. Also document which value is the default. Fixes nodejs#37896.
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Darwin dsg-mbp 18.7.0 Darwin Kernel Version 18.7.0: Tue Nov 10 00:07:31 PST 2020; root:xnu-4903.278.51~1/RELEASE_X86_64 x86_64
(but issue is not platform-specific)src/node_options.cc
What steps will reproduce the bug?
In #33475, @dfabulich added two new legal values for
--unhandled-rejection
:throw
andwarn-with-error-code
. These new values are not listed in the help string innode --help
. Additionally, the help string doesn't explain which is the default value.How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
The documentation of
--unhandled-rejections
in--help
should list all legal values or not attempt to provide a list of legal values, and it should say what the default value is.What do you see instead?
Only strict, warn, and none, as shown above.
Additional information
I'd file a PR but I'm not sure I know how to describe the two new values in a concise way. (One option would be to remove the parenthesized explanations and just link to the docs for more details.)
The text was updated successfully, but these errors were encountered: