-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unref FSWatcher #33096
Comments
I found fs.unwatchFile(filename[, listener]), or you mean something different? |
@juanarbol |
I'm more interested in this part, can you let me try work it ? @addaleax |
@rickyes Sure! Basically, this would require adding For the
For the |
@szmarczak I looked at the implementation logic and maybe |
Indeed, thanks. I'd still go for |
PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: #35555 PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: #35555 PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: nodejs/node#33134 Fixes: nodejs/node#33096 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Is your feature request related to a problem? Please describe.
Currently, when you do
fs.watchFile(...)
the process will run forever.Describe the solution you'd like
A possibility to
watcher.unref()
would be great.Describe alternatives you've considered
Edit: seems like the code above is completely unnecessary 🤦♂️
The text was updated successfully, but these errors were encountered: