-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation writable stream example confusing order #30759
Comments
@GrosSacASac i would like to work on this issue. |
Hello @GrosSacASac , i want to ask one query. The 'finish' event is emitted after the stream.end() method has been called, and all data has been flushed to the underlying system. so here i have to change 'after the stream.end()' line also. |
I am not sure what you mean exactly ? You can always make a PR it does not need to be perfect, you can always do follow up commits if something needs to be changed. |
ok |
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889 Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889 Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889 Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
should be before
https://nodejs.org/api/stream.html#stream_event_finish
The text was updated successfully, but these errors were encountered: