Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override arm_fpu config #2942

Closed
kapouer opened this issue Sep 18, 2015 · 6 comments
Closed

Cannot override arm_fpu config #2942

kapouer opened this issue Sep 18, 2015 · 6 comments
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.

Comments

@kapouer
Copy link
Contributor

kapouer commented Sep 18, 2015

Hi,
When building nodejs for debian armel, one must set arm_fpu to "vfp".
Alas, -Darm_fpu=fvp is overriden by https://github.com/nodejs/node/blob/master/configure#L613.
Is it possible to check if arm_fpu is set in configure before setting it ?
@kapouer
Copy link
Contributor Author

kapouer commented Sep 18, 2015

Forgot basic information like nodejs version 4.0.0

@brendanashworth brendanashworth added question Issues that look for answers. arm Issues and PRs related to the ARM platform. labels Sep 18, 2015
@bnoordhuis
Copy link
Member

It would need a new configure flag but that's pretty straightforward, you can use the logic for --with-mips-fpu-mode as a template.

@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. and removed question Issues that look for answers. labels Sep 18, 2015
@kapouer
Copy link
Contributor Author

kapouer commented Sep 18, 2015

Here's what i meant, but i'm not sure it works.

@bnoordhuis
Copy link
Member

I don't think that works, assuming -Darm_fpu=fvp is what needs to be passed to gyp. The configure script runs before gyp's configure step; no variables have been set at that point yet.

@kapouer
Copy link
Contributor Author

kapouer commented Sep 18, 2015

Oh, got it.

@kapouer
Copy link
Contributor Author

kapouer commented Sep 18, 2015

This is better, i'll test it a little and submit a PR !

@kapouer kapouer mentioned this issue Oct 6, 2015
Closed
jasnell pushed a commit that referenced this issue Oct 8, 2015
@kapouer @jasnell
build: add --with-arm-fpu option
b3c5ad1 
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Brian White <[email protected]>
This was referenced Jul 16, 2020
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 29, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jan 17, 2022
Open
@KamilPolivka KamilPolivka mentioned this issue Jun 29, 2022
Open
@saeedahassan saeedahassan mentioned this issue Jun 29, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 29, 2022
Open
@UbuntuEvangelist UbuntuEvangelist mentioned this issue Jun 30, 2022
Open
@saurabharch saurabharch mentioned this issue Jun 30, 2022
Open
@erdun erdun mentioned this issue Jun 30, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 30, 2022
Open
@olegnn olegnn mentioned this issue Jun 30, 2022
Open
@s4sc s4sc mentioned this issue Jun 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kapouer @bnoordhuis @brendanashworth