Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-vm-syntax-error-stderr #2660

Closed
joaocgreis opened this issue Sep 2, 2015 · 6 comments
Closed

Investigate flaky test test-vm-syntax-error-stderr #2660

joaocgreis opened this issue Sep 2, 2015 · 6 comments
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Sep 2, 2015
joaocgreis added a commit to JaneaSystems/node that referenced this issue Sep 2, 2015
@joaocgreis
test: mark test-vm-syntax-error-stderr as flaky
6d7659a 
Ref: nodejs#2660
@joaocgreis joaocgreis mentioned this issue Sep 2, 2015
Closed
@Fishrock123
Copy link
Contributor 

not ok 922 - test-vm-syntax-error-stderr.js
# net.js:523
# var ret = self.push(buffer);
# ^
# 
# TypeError: Cannot read property 'objectMode' of undefined
# at Pipe.onread (net.js:523:20)

Uh, this looks like something's stdio failed to spawn? That's not good.

joaocgreis added a commit that referenced this issue Sep 2, 2015
@joaocgreis
test: mark test-vm-syntax-error-stderr as flaky
68a658d 
Ref: #2660

PR-URL: #2662
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
joaocgreis added a commit that referenced this issue Sep 3, 2015
@joaocgreis @Fishrock123
test: mark test-vm-syntax-error-stderr as flaky
93ba585 
Ref: #2660

PR-URL: #2662
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Sep 3, 2015
@joaocgreis @Fishrock123
test: mark test-vm-syntax-error-stderr as flaky
1865cad 
Ref: nodejs#2660

PR-URL: nodejs#2662
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
@whitlockjc
Copy link
Contributor

Mind adding an arm label?

@Fishrock123 Fishrock123 added the arm Issues and PRs related to the ARM platform. label Oct 22, 2015
@Fishrock123
Copy link
Contributor

@whitlockjc Done. :)

@Fishrock123
Copy link
Contributor

@joaocgreis I suggest we close this. I am quite sure this was the result of some awful jenkins misconfiguration somewhere, I haven't seen the armv7 bot go conditional pass recently.

@whitlockjc
Copy link
Contributor

I would offer to help but I don't have an arm environment.

@joaocgreis
Copy link
Member Author

@Fishrock123 The armv7 machines have been replaced since this was opened, and they are much more stable now. I haven't seen this fail recently either, so let's blame the old machines for now and reopen this if it fails again.

@santigimeno santigimeno mentioned this issue Feb 26, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Feb 26, 2016
@Trott
test: remove flaky designation from fixed tests
6a39eb3 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
@Trott Trott mentioned this issue Feb 26, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Feb 29, 2016
@Trott
test: remove flaky designation from fixed tests
4d6b4c3 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
PR-URL: nodejs#5459
Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this issue Mar 2, 2016
@Trott @Fishrock123
test: remove flaky designation from fixed tests
0ebbf6c 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@Trott
test: remove flaky designation from fixed tests
48d069d 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@Trott
test: remove flaky designation from fixed tests
f242e62 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitlockjc @joaocgreis @Fishrock123