Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-doc failed to add alternative version links #25682

Closed
targos opened this issue Jan 24, 2019 · 1 comment
Closed

test-doc failed to add alternative version links #25682

targos opened this issue Jan 24, 2019 · 1 comment

Comments

@targos
Copy link
Member

targos commented Jan 24, 2019

Just saw this in my console output:

make -s test-doc
Failed to add alternative version links to policy
Failed to add alternative version links to report
@targos targos changed the title test-doc failed to add alternative test-doc failed to add alternative version links Jan 24, 2019
@Trott
Copy link
Member

Trott commented Jan 25, 2019

This will happen if policy.md or report.md have <!--introduced_in=REPLACEME--> instead of something like <!--introduced_in=v11.7.0--> or if they lack an introduced_in at all.

This is a harmless warning in the case of REPLACEME. You should not see those warnings on release tags, but they're fine on master.

For policy, this was fixed in 641de82.

For report, this is still an issue as introduced_in does not appear in report.md. But you will only see it if you force it to build (for example by removing out/doc/api/report.* before running make -s test-doc).

A PR to add introduced_in for report.md should be opened, if it hasn't already been opened. The entire report.md could probably use a review by one or more folks on @nodejs/documentation.

richardlau added a commit to richardlau/node-1 that referenced this issue Jan 25, 2019
addaleax pushed a commit that referenced this issue Jan 28, 2019
Fixes: #25682

PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants