Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE update: src/large_pages/* is MIT-licensed by Intel #25238

Closed
kapouer opened this issue Dec 27, 2018 · 3 comments
Closed

LICENSE update: src/large_pages/* is MIT-licensed by Intel #25238

kapouer opened this issue Dec 27, 2018 · 3 comments
Assignees
@ryzokuken

Comments

@kapouer
Copy link
Contributor

kapouer commented Dec 27, 2018

node 10.15 has a license for src/large_pages/* that is not listed in LICENSE.
@ryzokuken
Copy link
Contributor

/cc @addaleax since she's handled similar changes in the past.

@Trott
Copy link
Member

Trott commented Dec 27, 2018

If someone wants to do this: Add an entry to tools/license-builder.sh, run it, and commit the result (both the change to license-build.sh and the changes it applies to the LICENSE file after running) to a branch. Then open a PR.

@ryzokuken
Copy link
Contributor

@Trott on it.

ryzokuken added a commit to ryzokuken/node that referenced this issue Dec 28, 2018
@ryzokuken
doc: include license for src/large_pages in LICENSE
c27b8eb 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: nodejs#25238
@ryzokuken ryzokuken mentioned this issue Dec 28, 2018
Closed
4 tasks
@ryzokuken ryzokuken self-assigned this Dec 28, 2018
@Trott Trott closed this as completed in 48a88c8 Dec 31, 2018
targos pushed a commit that referenced this issue Jan 1, 2019
@ryzokuken @targos
doc: include license for src/large_pages in LICENSE
8a701c3 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@ryzokuken @refack
doc: include license for src/large_pages in LICENSE
332d809 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: nodejs#25238

PR-URL: nodejs#25246
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 28, 2019
@ryzokuken @BethGriggs
doc: include license for src/large_pages in LICENSE
eebcb8b 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this issue May 10, 2019
@ryzokuken @BethGriggs
doc: include license for src/large_pages in LICENSE
eb18124 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@ryzokuken @MylesBorins
doc: include license for src/large_pages in LICENSE
fc5dc9c 
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzokuken ryzokuken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: include license for src/large_pages in LICENSE ryzokuken/node
3 participants
@kapouer @Trott @ryzokuken