-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: expose scatter/gather syscalls writev() and readv() #2298
Comments
@reqshark Can you elaborate a little on this? Or maybe link to the specific comment in the PR that you're referring to? Apologies in advance for my ignorance. |
@Trott oh ok, I remember now what this was about. i was just thinking how cool would it be to do API would operate by using this would open the door to more efficient I/O for a wide variety of buffer sizes |
#2167 landed. Anyone thinking this feature is a good idea and willing to try to implement and submit a pull request? |
Put into https://github.com/nodejs/node/projects/13 backlog |
@refack did you intentionally change the title from "scatter/gather" to "setter/getter"? |
nice catch @zbjornson! |
Fwiw, I’d like to reopen this. It’s not a trivial first contribution, but if you know some C++ and can copy-paste the rest together, this should be doable (and I’m happy to help), so I’m adding |
@addaleax Is this still available, If yes I would like to pick it up and work on it as my first contribution, and definitely I will need your guidance. |
@anasfullstack Awesome! I think your best point to start would be to look at how |
has this issue gone |
For anyone interested, all the issues in https://github.com/nodejs/node/projects/13 are looking for someone to "adopt" them. In general they represent ideas that did not raise objections, but have no champion to push them forward. |
fs with writev allow many buffers to be pushed to underlying OS APIs in one batch, so this should improve write speed to files. Refs: #2298 PR-URL: #25925 Fixes: #2298 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #2298 PR-URL: #32356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #2298 PR-URL: #32356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs#2298 PR-URL: nodejs#32356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #2298 PR-URL: #32356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
fs with writev allow many buffers to be pushed to underlying OS APIs in one batch, so this should improve write speed to files. Refs: nodejs/node#2298
with the awesome work achieved here by @ronkorving in libuv/libuv@2bf7827
the upcoming libuv release will unblock #2167
first mentioned by @trevnorris in that PR, i think it makes a lot of sense to expose scatter/gather syscalls
writev
and alsoreadv
from node.jsThe text was updated successfully, but these errors were encountered: