Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: client request req & res 'close' order is inconsistent #20102

Closed
ronag opened this issue Apr 17, 2018 · 0 comments
Closed

http: client request req & res 'close' order is inconsistent #20102

ronag opened this issue Apr 17, 2018 · 0 comments
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Apr 17, 2018

The order in which close is emitted on the http.ClientRequest request and response object is inconsistent depending on the situation.

See e2e18ae and #20075

@lpinca lpinca added the http Issues or PRs related to the http subsystem. label Apr 18, 2018
@ronag ronag mentioned this issue Apr 25, 2018
3 tasks
ronag added a commit to nxtedition/node that referenced this issue Apr 27, 2018
Fixes: nodejs#20102
Fixes: nodejs#20101
Fixes: nodejs#1735

- Response should always emit close.
- Response should always emit aborted if aborted.
- Response should always emit close after request has emitted close.
addaleax pushed a commit that referenced this issue May 14, 2018
Fixes: #20102
Fixes: #20101
Fixes: #1735

- Response should always emit close.
- Response should always emit aborted if aborted.
- Response should always emit close after request has emitted close.

PR-URL: #20075
Fixes: #17352
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants