Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc events: Erroneous use of effects #16793

Closed
gowpen opened this issue Nov 6, 2017 · 0 comments
Closed

doc events: Erroneous use of effects #16793

gowpen opened this issue Nov 6, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Comments

@gowpen
Copy link
Contributor

gowpen commented Nov 6, 2017

  • Version: v9.0.0

The docs contain an erroneous use of effects where the intended meaning seems to be affects.

Location:

Current text:

.. because the change effects all EventEmitter instances, ..

Proposed correct text:

.. because the change affects all EventEmitter instances, ..
gowpen added a commit to gowpen/node that referenced this issue Nov 6, 2017
@gowpen
doc events: correct effects to affects
a6409a2 
Fixes: nodejs#16793
@gowpen gowpen mentioned this issue Nov 6, 2017
Closed
3 tasks
@mscdex mscdex added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Nov 6, 2017
@jasnell jasnell closed this as completed in 52e8454 Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 6, 2017
@gowpen @cjihrig
doc: correct effects to affects
e05d4f4 
PR-URL: nodejs#16794
Fixes: nodejs#16793
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 14, 2017
@gowpen @MylesBorins
doc: correct effects to affects
6b9bd51 
PR-URL: #16794
Fixes: #16793
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 19, 2017
@gowpen @gibfahn
doc: correct effects to affects
9df93c4 
PR-URL: #16794
Fixes: #16793
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
@gowpen @gibfahn
doc: correct effects to affects
58cd649 
PR-URL: #16794
Fixes: #16793
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc events: correct effects to affects gowpen/node
2 participants
@mscdex @gowpen